refactor: extract nuget package publish workflow#201
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04b53bb71d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var roots = (request.Roots ?? Array.Empty<string>()) | ||
| .Where(path => !string.IsNullOrWhiteSpace(path)) | ||
| .Distinct(StringComparer.OrdinalIgnoreCase) | ||
| .ToArray(); |
There was a problem hiding this comment.
The new service normalizes request.Roots with Distinct(StringComparer.OrdinalIgnoreCase) before file discovery, which can silently drop valid publish roots on case-sensitive filesystems (for example, /repo/Foo and /repo/foo are distinct directories on Linux). In that scenario, packages in the dropped directory are never considered and the cmdlet can incorrectly report no packages found, whereas the previous implementation processed both roots.
Useful? React with 👍 / 👎.
Code Review: PR 201 |
1 participant
Summary
Publish-NugetPackagepackage discovery and push execution into a reusable PowerForge workflow serviceShouldProcess, and output mappingValidation
dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --filter "NuGetPackagePublishServiceTests|DotNetRepositoryReleaseServiceTests|CommentRemovalServiceTests"pwsh .\Module\Build\Build-Module.ps1 -NoSign