Add unified staged release publishing#310
Conversation
Code ReviewOverall this is a clean, well-structured addition. The orchestration logic is properly separated, the tests cover the happy path, and the schema/docs are in sync. A few things worth addressing: SecurityDirect token in Token file size ( Code QualityDuplicate template method (
Redundant null-forgiving operators Double-write of summary files Test CoverageThe two new tests cover the main happy path well. Missing edge cases:
The failure-path tests matter here because errors are surfaced as a Minor / Nits
Overall the implementation is solid and the feature is well-scoped. The main asks are: test the error paths, consider exposing |
Summary
GitHubsection topowerforge releaseso stagedUploadReadyassets can publish as one repo releaseValidation
dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --filter "PowerForgeReleaseServiceTests"dotnet build .\PowerForge.Cli\PowerForge.Cli.csproj -c Release -f net10.0dotnet build .\PSPublishModule\PSPublishModule.csproj -c Release -f net8.0dotnet build .\PSPublishModule\PSPublishModule.csproj -c Release -f net472