Remove site-specific PowerForge public docs#342
Conversation
Code Review: Remove site-specific PowerForge public docsOverviewThis PR performs a documentation hygiene cleanup — removing internal/private content that had leaked into the public engine repository, and genericizing concrete product/organization names in the remaining docs. All changes are documentation only (no source code, no schema changes, no tests). Net: −1,176 lines across 11 files. What's removed and why it's appropriateDeleted files (3 large files, ~1,009 lines):
These deletions are clearly the right call — none of this material should be in a public generic engine repository. Genericization qualityThe remaining docs have product names replaced with generic placeholders:
These substitutions are consistent and the resulting examples read naturally as generic documentation. Issues and suggestionsMinor: One internal path remains in the diff context (not addressed by this PR) In "GitHubAccessTokenFilePath": "C:\\Support\\Important\\GithubAPI.txt"This is an absolute Windows path to what appears to be an internal credential file location. It doesn't expose the credential itself, but it leaks internal machine layout. Consider replacing it with a placeholder like Minor: In The two remaining reference entries still list Minor: Deleted implementation plan contained useful DSL shape documentation
Security / information disclosureThe primary security concern this PR addresses is information disclosure: internal paths, private repo names, and internal tooling details were inadvertently committed to a public repo. The PR correctly addresses this. No new security issues are introduced. SummaryThis is a clean, focused PR with a clear and correct goal. The deletions remove material that has no place in a public engine repo. The genericization changes are consistent and well-executed. The one leftover internal path ( Verdict: Approve with optional follow-up on the remaining internal path in |
721cc18 to
0b9deee
Compare
Code Review — PR #342: Remove site-specific public docsOverviewThis PR is a documentation hygiene / privacy cleanup. It removes Evotec/site-specific material from this public engine repository and genericizes examples in the remaining docs. No functional code (PowerShell, C#, schemas) is changed. Net change: −1,381 / +205 lines, all in What's Being Removed
The deletions are well-justified. All removed files contain one or more of: local Windows absolute paths meaningless to external users, references to private/internal repositories, proprietary product names and operational notes that are not engine-level knowledge. Genericization QualityThe substitutions in surviving docs are reasonable and consistent:
One minor note: in Potential Concerns1. Loss of
2. The removed prompts contained 3. No orphaned references checked A few surviving docs previously cross-referenced the deleted files by filename:
It's worth a quick Summary✅ The purpose is clear and the execution is clean. Recommendation: approve and merge. |
Summary
Validation