Skip to content

Remove site-specific PowerForge public docs#342

Merged
PrzemyslawKlys merged 1 commit intomainfrom
codex/powerforge-public-doc-cleanup
May 3, 2026
Merged

Remove site-specific PowerForge public docs#342
PrzemyslawKlys merged 1 commit intomainfrom
codex/powerforge-public-doc-cleanup

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • remove Evotec Website handoff/blueprint material from the public PowerForge engine repository
  • remove CodeGlyphX-specific build/plan notes and genericize remaining PowerForge.Web docs
  • trim the bundled website-starter skill so it does not expose agent prompt playbooks as public product material

Validation

  • git diff --check

@claude
Copy link
Copy Markdown

claude Bot commented May 3, 2026

Code Review: Remove site-specific PowerForge public docs

Overview

This PR performs a documentation hygiene cleanup — removing internal/private content that had leaked into the public engine repository, and genericizing concrete product/organization names in the remaining docs. All changes are documentation only (no source code, no schema changes, no tests). Net: −1,176 lines across 11 files.


What's removed and why it's appropriate

Deleted files (3 large files, ~1,009 lines):

File Reason for removal
Docs/PowerForge.Web.AgentHandoff.md Contains hardcoded absolute Windows paths (C:\Support\GitHub\...), site-specific Evotec deployment metrics, and internal agent-scope notes. Not appropriate in a public engine repo.
Docs/PSPublishModule.DotNetPublish.ImplementationPlan.md Internal backlog/TODO with line-number cross-references to private repos and Windows paths. This is internal planning material, not engine documentation.
Docs/PowerForge.Web.CodeGlyphX.Build.md A product-specific build guide for CodeGlyphX. Belongs in the CodeGlyphX repo, not the engine.
.agents/skills/.../references/agent-prompts.md Agent prompts with hardcoded C:\\Support\\GitHub\\HtmlForgeX\\Website paths and product-specific instructions. Correct to remove.

These deletions are clearly the right call — none of this material should be in a public generic engine repository.


Genericization quality

The remaining docs have product names replaced with generic placeholders:

  • IntelligenceX / IntelligenceX.Chat.AppExampleApp
  • EvotecIT (as a GitHub org) → ExampleOrg
  • TestimoX / TierBridge / Sectigo → "service/installer-heavy repos" or "multi-project sites"
  • HtmlForgeX.ApexAxisTitleExampleCharts.AxisTitle
  • OfficeIMO suite → ExampleSuite
  • intelligencex theme references → example

These substitutions are consistent and the resulting examples read naturally as generic documentation.


Issues and suggestions

Minor: One internal path remains in the diff context (not addressed by this PR)

In Docs/PSPublishModule.ProjectBuild.md, this line is unchanged and still appears in docs:

"GitHubAccessTokenFilePath": "C:\\Support\\Important\\GithubAPI.txt"

This is an absolute Windows path to what appears to be an internal credential file location. It doesn't expose the credential itself, but it leaks internal machine layout. Consider replacing it with a placeholder like "C:\\path\\to\\GithubAPI.txt" in a follow-up.

Minor: SKILL.md reference removal leaves a dangling sentence

In .agents/skills/powerforge-website-starter/SKILL.md, the line removed is:

- `references/agent-prompts.md`: copy/paste prompts for Claude/agents (new site, refactor theme, fix api docs).

The two remaining reference entries still list blueprint.md and theme-contracts.md. The section now ends abruptly after two entries with no closing context. This is fine for correctness but could optionally note that prompt playbooks are maintained separately.

Minor: Deleted implementation plan contained useful DSL shape documentation

PSPublishModule.DotNetPublish.ImplementationPlan.md had a well-structured JSON/PowerShell DSL shape proposal and canonical pipeline step order that might be valuable to contributors. Consider whether a stripped-down, generic version of just the DSL examples (without the internal backlog, Windows paths, or repo-specific file references) belongs in a separate Docs/PowerForge.DotNetPublish.DslReference.md. Not blocking — the Quickstart and other docs cover the basics.


Security / information disclosure

The primary security concern this PR addresses is information disclosure: internal paths, private repo names, and internal tooling details were inadvertently committed to a public repo. The PR correctly addresses this. No new security issues are introduced.


Summary

This is a clean, focused PR with a clear and correct goal. The deletions remove material that has no place in a public engine repo. The genericization changes are consistent and well-executed. The one leftover internal path (GithubAPI.txt) is worth a quick follow-up but is not a blocker.

Verdict: Approve with optional follow-up on the remaining internal path in PSPublishModule.ProjectBuild.md.

@PrzemyslawKlys PrzemyslawKlys force-pushed the codex/powerforge-public-doc-cleanup branch from 721cc18 to 0b9deee Compare May 3, 2026 19:39
@claude
Copy link
Copy Markdown

claude Bot commented May 3, 2026

Code Review — PR #342: Remove site-specific public docs

Overview

This PR is a documentation hygiene / privacy cleanup. It removes Evotec/site-specific material from this public engine repository and genericizes examples in the remaining docs. No functional code (PowerShell, C#, schemas) is changed.

Net change: −1,381 / +205 lines, all in .md files and one skill definition file.


What's Being Removed

File Lines Reason
Docs/PowerForge.Web.AgentHandoff.md 440 Contains local C:\Support\GitHub\... paths, Evotec-specific site status, private product names
Docs/PowerForge.Web.CodeGlyphX.Build.md 229 CodeGlyphX-specific build mapping — product policy, not engine docs
Docs/PowerForge.Web.CodeGlyphX.Plan.md 41 Site-specific migration plan
Docs/PowerForge.Web.EvotecBlueprint.md 78 Evotec website IA/deployment blueprint
Docs/PSPublishModule.DotNetPublish.ImplementationPlan.md 337 Extensive cross-repo path references (C:/Support/GitHub/TestimoX/...)
.agents/skills/.../references/agent-prompts.md 48 Copy/paste agent prompts with local absolute paths

The deletions are well-justified. All removed files contain one or more of: local Windows absolute paths meaningless to external users, references to private/internal repositories, proprietary product names and operational notes that are not engine-level knowledge.


Genericization Quality

The substitutions in surviving docs are reasonable and consistent:

  • evotec.pl/kontakt/example.pl/kontakt/
  • IntelligenceXExampleApp / ExampleDocs
  • EvotecIT/IntelligenceXExampleOrg/ExampleApp
  • C:\\Support\\Important\\NugetOrgEvotec.txtC:\\path\\to\\nuget-api-key.txt
  • TestimoX-specific doc references → generic "multi-project API sites" ✓
  • --workspace-testimox-root CLI flag → --workspace-external-root <name=path> ✓ (this one is a functional-looking change but is in a doc-only markdown table, so it's fine)

One minor note: in PSPublishModule.DotNetPublish.PluginCatalogProposal.md the example JSON uses "private-tool" and "PrivateTool" as replacements for "testimox" / "TestimoX". These names are less illustrative than a neutral name like "analytics-tool", but they don't cause confusion and the surrounding prose is clear.


Potential Concerns

1. Loss of ImplementationPlan.md detail

PSPublishModule.DotNetPublish.ImplementationPlan.md contains a detailed PR wave plan, canonical pipeline step order, and DSL shape proposals that have value beyond the specific repos it referenced. Since those proposals appear to already be implemented (all P0–P5 checkboxes are ticked), deleting the planning doc is reasonable — the plan's output is the shipped code. No concern here.

2. agent-prompts.md deletion

The removed prompts contained C:\\Support\\GitHub\\HtmlForgeX\\Website absolute paths — they would be unusable by anyone other than the original author. Removing them from the public skill reference is correct. The skill's SKILL.md index line referencing the file is also removed cleanly.

3. No orphaned references checked

A few surviving docs previously cross-referenced the deleted files by filename:

  • Docs/PowerForge.Web.AgentHandoff.md was listed as a "start here" pointer in the deleted file itself, so no external doc now points to it.
  • The skill SKILL.md correctly removes its references/agent-prompts.md bullet.

It's worth a quick grep -r "AgentHandoff\|CodeGlyphX.Build\|CodeGlyphX.Plan\|EvotecBlueprint\|ImplementationPlan\|agent-prompts" Docs/ .agents/ pass to confirm no remaining dangling references, but this is low risk given the scope.


Summary

✅ The purpose is clear and the execution is clean.
✅ Deletions are appropriate — private operational notes do not belong in a public engine repo.
✅ Genericizations in retained docs are consistent and informative.
✅ No functional code is affected.
⚠️ Minor: consider a quick grep for leftover references to deleted files before merging (low risk).

Recommendation: approve and merge.

@PrzemyslawKlys PrzemyslawKlys merged commit 6665d72 into main May 3, 2026
5 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/powerforge-public-doc-cleanup branch May 3, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant