Skip to content

Fix approved required-module publish validation#409

Merged
PrzemyslawKlys merged 1 commit into
mainfrom
codex/fix-approved-required-publish-check
May 28, 2026
Merged

Fix approved required-module publish validation#409
PrzemyslawKlys merged 1 commit into
mainfrom
codex/fix-approved-required-publish-check

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • Make repository publish dependency validation trust the final module manifest when it exists, including when RequiredModules is empty.
  • Add regression coverage for a module configured as both required and approved so approved/merged modules do not reappear during publish validation.
  • Keep the missing-manifest fallback to the planned required modules for defensive scenarios.

Root cause

Publish validation only used the final manifest when it contained at least one RequiredModules entry. When approved-module merge removed the last dependency from the manifest, validation fell back to the unfiltered plan and checked the dependency against PSGallery anyway.

Validation

  • dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --filter "FullyQualifiedName~ModulePublisherRequiredModulesTests|FullyQualifiedName~ModulePipelineApprovedModulesTests|FullyQualifiedName~RequiredModuleResolutionEngineTests"

@PrzemyslawKlys PrzemyslawKlys merged commit c9d2345 into main May 28, 2026
6 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/fix-approved-required-publish-check branch May 28, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant