Add bundled sitemap protocol schemas#415
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44d7713ffd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PrzemyslawKlys
force-pushed
the
codex/powerforge-sitemap-schema-cache
branch
from
44d7713 to
eb74aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sitemap.xsdandsiteindex.xsdin PowerForge.Web so CI and downstream sites do not depend on fetchingwww.sitemaps.orgWebSitemapProtocolSchemaspluspowerforge-web sitemap-schemas --out <dir>for consumers that need local schema filesValidation
dotnet test PowerForge.Tests/PowerForge.Tests.csproj -c Debug --filter FullyQualifiedName~WebSitemapProtocolSchemasTests /m:1 /nr:falsedotnet build PowerForge.Web.Cli/PowerForge.Web.Cli.csproj -c Debug -f net10.0 /m:1 /nr:falsedotnet run --project PowerForge.Web.Cli/PowerForge.Web.Cli.csproj -c Debug --framework net10.0 -- sitemap-schemas --out <temp>dotnet test DomainDetective.Tests/DomainDetective.Tests.csproj -c Debug --filter FullyQualifiedName~TestSitemapAnalysis /m:1 /nr:falsepassed for net472, net8.0, and net10.0; DomainDetective already embeds its own sitemap analyzer schemas.