Add Graph authentication isolation profile#418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MicrosoftGraphAuthenticationisolation profile forImport-IsolatedModuleNestedModules, and remove copied Authenticode signature blocks after patchingWhy
Microsoft.Graph.Authenticationcan collide with assemblies already loaded by hosts such as the VS Code PowerShell extension, especially in sessions where other assembly-loading modules such as DLLPickle are present. The profile keeps Graph/Kiota/Auth assemblies in the module-specific ALC instead of loading them intoAssemblyLoadContext.Default.Validation
dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --filter "ModuleIsolation|IsolatedModule"dotnet build .\PSPublishModule\PSPublishModule.csproj -c Releasegit diff --checkMicrosoft.Graph.Authentication2.37.0: 18 commands exported,Get-MgContextresolves fromMicrosoft.Graph.Authentication.ALC, default Graph assembly count stays 0DLLPickle2.2.0 imported first andMicrosoft.Graph.Authentication2.36.1 loaded by explicit path: 18 commands exported,Get-MgContextresolves fromMicrosoft.Graph.Authentication.ALC, default Graph assembly count stays 0Notes
A full unfiltered
PowerForge.Testsproject run was started but stayed silent after discovery for over two minutes, so it was stopped. The focused isolation tests, multi-target module build, and live Graph/DLLPickle smoke checks passed.