Add opt-in isolated module resolution preference#423
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a7f0e5021
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import-IsolatedModule -PreferIsolatedModulePathas an opt-in process-scoped resolution preferencePSModulePathonly after the isolated import succeeds-PassThruoutput and document the downstream-module workflowWhy
Some consumer modules call
Import-Module ExchangeOnlineManagementinternally after the caller already connected through an isolated Exchange profile. By default, those nested imports can resolve the original installed module again and bypass the isolated copy. This switch gives callers an explicit way to prefer the generated isolated module path for later name-based imports in the same PowerShell process, without changing default behavior.Validation
dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --filter "IsolatedModuleImportServiceTests|ModuleIsolationScriptPatcherTests|ModuleIsolationProfileRegistryTests"dotnet build .\PowerForge.PowerShell\PowerForge.PowerShell.csproj -c Release -f net472 --nologo.\Module\Build\Build-Module.ps1 -NoDotnetBuildpwsh -NoLogo -NoProfile -File .\Module\PSPublishModule.Tests.ps1Import-IsolatedModule -Profile ExchangeOnlineManagement -PreferIsolatedModulePath -PassThru, then a laterImport-Module ExchangeOnlineManagementresolved from the generated isolated work path