Skip to content

Address packaged ALC review feedback#81

Merged
PrzemyslawKlys merged 1 commit into
mainfrom
codex/pswriteoffice-pr80-review-fixes
May 10, 2026
Merged

Address packaged ALC review feedback#81
PrzemyslawKlys merged 1 commit into
mainfrom
codex/pswriteoffice-pr80-review-fixes

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • import the published PSPublishModule dependency once with -MinimumVersion 3.0.5 instead of probing/removing alternate module candidates in-process
  • make the packaged ALC conflict test fail when the packaged module, ALC loader, or conflict OpenXML assembly is missing
  • add bounded timeout values to the CI NuGet download used by the ALC conflict job

Validation

  • git diff --check
  • Import-Module PSPublishModule -MinimumVersion 3.0.5 and verify New-ConfigurationBuild exposes NETAssemblyLoadContext
  • Build/Manage-PSWriteOffice.ps1 with signing disabled
  • Build/Validate-PackagedArtefact.ps1 -SkipBuild
  • Tests/AssemblyLoadContext.Conflict.Tests.ps1 fails without PSWRITEOFFICE_CONFLICT_OPENXML_PATH and passes with the conflict assembly path set

@PrzemyslawKlys PrzemyslawKlys force-pushed the codex/pswriteoffice-pr80-review-fixes branch from 4060c9a to f4b900e Compare May 10, 2026 17:22
@PrzemyslawKlys PrzemyslawKlys merged commit 6ba2bf6 into main May 10, 2026
9 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/pswriteoffice-pr80-review-fixes branch May 10, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant