Skip to content

Conversation

@Mar1ki
Copy link

@Mar1ki Mar1ki commented Oct 25, 2024

Description

Describe the changes
Added Fix

Patches (if there are any changes related to Harmony patches)

  • No Errors In Console

Other

  • Still requires more testing on This Version of Exiled

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to target dev branch and pls fix build

@Mar1ki
Copy link
Author

Mar1ki commented Oct 25, 2024

how to change target branch to dev, if i forked main?

@Mar1ki Mar1ki changed the base branch from master to dev October 25, 2024 17:59
@Mar1ki Mar1ki requested a review from VALERA771 October 25, 2024 18:10
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments needed it's fine

@Mar1ki Mar1ki requested a review from IRacle1 October 26, 2024 12:22
@Mar1ki
Copy link
Author

Mar1ki commented Oct 26, 2024

I have reversed my changes, couse of that code not working as planned.

@Mar1ki Mar1ki requested a review from IRacle1 October 26, 2024 15:59
Copy link
Member

@IRacle1 IRacle1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you sure that current version work😉

@Mar1ki
Copy link
Author

Mar1ki commented Oct 26, 2024

Just checked on my friends server
cbdbd6c3-fecf-4935-a9ff-89c01adfe2ea
this one without fix
73dd29e2-9bcb-40ff-bdec-d56508247cd8
this with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants