feat: Have NPC In Player List#445
Merged
louis1706 merged 1 commit intoExMod-Team:devfrom Feb 25, 2025
TtroubleTT:npc-fix
Merged
feat: Have NPC In Player List#445louis1706 merged 1 commit intoExMod-Team:devfrom TtroubleTT:npc-fix
louis1706 merged 1 commit intoExMod-Team:devfrom
TtroubleTT:npc-fix
Conversation
obvEve
approved these changes
Feb 24, 2025
VALERA771
approved these changes
Feb 24, 2025
|
Wouldn't that be a breaking change ? For plugin ? |
Author
|
I asked nameless if it was considered a breaking change and she said no. I can change it tho |
Member
This was intended behaviour, and was broken in a PR for 14.0 |
|
What if we make a property that determines whether an NPC should appear in the Player.List? We can also add a property to the config that specifies whether NPC spawned via RA should be in Player.List. |
Member
|
just go back to old behaviour, plugins can handle it with .IsNpc check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Has NPCs in Player.List like the poll wanted.
What is the current behavior? (You can also link to an open issue here)
NPCs arent in Player.List which makes them unusable for testing.
What is the new behavior? (if this is a feature change)
NPCs are now in Player.List
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other