Skip to content

Conversation

@obvEve
Copy link
Member

@obvEve obvEve commented Sep 5, 2024

Description

Describe the changes

  • Add Player::SetScale(Vector3, IEnumerable)
  • Add Player::SetFakeScale(Vector3, IEnumerable)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@obvEve
Copy link
Member Author

obvEve commented Sep 6, 2024

"I tested it, it was fine" -Alex

@obvEve obvEve added the enhancement New feature or request label Sep 6, 2024
@IkaRest
Copy link

IkaRest commented Sep 7, 2024

why "size" and not "scale", to be in par with the rest

@vladflotsky
Copy link

why "size" and not "scale", to be in par with the rest

Wanted to say it too

@obvEve
Copy link
Member Author

obvEve commented Sep 7, 2024

why "size" and not "scale", to be in par with the rest
idk i didnt rly think of it while writing it

Copy link

@vladflotsky vladflotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change size to scale

@obvEve obvEve requested a review from vladflotsky September 10, 2024 18:38
Copy link

@vladflotsky vladflotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including size and fakeSize 😛

@Misaka-ZeroTwo
Copy link
Collaborator

Document your changes... Unless you want to write the changelog.

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but will be better if you find a good way to automatically set viewers to all players

@louis1706 louis1706 changed the title uwu Player::FakeScale Oct 19, 2024
@louis1706 louis1706 dismissed Jesus-QC’s stale review November 9, 2024 08:32

No respons for 3 week i believe he will not have time to integrated it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants