sign_transaction ignores signer overrides

[bamorim]

Hey, thanks for building such a library for the Elixir ecossystem. Much appreciated.

I've been playing around with your library and realized that the sign_transaction was ignoring the signer opts I'd pass into it:

Ethers.send_transaction(create_safe_tx, from: my_wallet, to: config["SAFE_PROXY_FACTORY_ADDRESS"], signer: Ethers.Signer.Local, signer_opts: [private_key: private_key])

This was failing and I realized that it was because it was using the JsonRPC. Looking at the code, I believe we should pass overrides to the get_signer function instead of opts, but since I'm new to the codebase and I currently don't have time to clone and test the repository (might try to do that later), I'm just reporting as it is (sorry).

[alisinabh]

Hey, Thank you for your interest in Ethers.

May I ask which version of ethers are you using?

I believe we should pass overrides to the get_signer function instead of opts

This should not be the case. Current version of Ethers will extract the signer and signer_opts keys from overrides and pass them to be used later.

  def send_transaction(tx_data, overrides \\ []) do
    # The below line will extract :siger and :signer_opts into opts variable
    {opts, overrides} = Keyword.split(overrides, @option_keys)

    {rpc_client, rpc_opts} = get_rpc_client(opts)

    with {:ok, tx_params, action} <- pre_process(tx_data, overrides, :send_transaction, opts) do
      apply(rpc_client, action, [tx_params, rpc_opts])
      |> post_process(tx_data, :send_transaction)
    end
  end

Also we have some tests in ethers_test.exs for sign_transaction with signer and custom signer_opts:

# test/ethers_test.exs:125
{:ok, tx_hash} =
  HelloWorldContract.set_hello("hello local signer")
  |> Ethers.send_transaction(
    from: @from,
    to: @to,
    signer: Ethers.Signer.Local,
    signer_opts: [
      private_key: @from_private_key
    ]
  )

This was failing and I realized that it was because it was using the JsonRPC

Can you share more info about this? How do you know it is using JsonRPC?

[bamorim]

Hey! Sorry. I tested again today and it kind of worked. I guess I was too sleep deprived. At the time I was getting {:error, %{"code" => -32602, "message" => "No Signer available"}}.

It was probably a typo, like the classic singer: instead of signer: 😂

[alisinabh]

Happy to see it worked. And believe me I make the worst typos 😄

Thanks