Install dependencies in the cloned dir rather than the dir where the … #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests are set up from. Also, make sure that dependencies are cleaned between branch tests since there are cases when pip doesn't downgrade correctly, which can lead to tests failing when they shouldn't.
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 69.84% 69.72% -0.12%
==========================================
Files 74 74
Lines 3164 3168 +4
==========================================
- Hits 2210 2209 -1
- Misses 954 959 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andre-merzky
approved these changes
Mar 21, 2023
Collaborator
andre-merzky
left a comment
andre-merzky
left a comment
There was a problem hiding this comment.
Makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tests
are set up from.
Also, make sure that dependencies are cleaned between branch tests since there are cases when pip doesn't downgrade correctly, which can lead to tests failing when they shouldn't.