update/SOF 7461 #145
Merged
update/SOF 7461 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
VsevolodX
commented
Oct 2, 2024
VsevolodX
commented
- upsdate: add get_materials wrapper
- update: add set_materials wrapper
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| { | ||
| "cell_type": "code", | ||
| "outputs": [], | ||
| "source": [ |
Member
There was a problem hiding this comment.
Line #4. FILM_INDEX = 1
FILM_INDEX = 1 # Index in the list of materials, to access as materials[FILM_INDEX]
Reply via ReviewNB
| { | ||
| "cell_type": "code", | ||
| "outputs": [], | ||
| "source": [ |
Member
There was a problem hiding this comment.
Line #8. print("Please select a film material. Film is set to substrate.")
Film material not found. Re-using substrate material as film.
Reply via ReviewNB
| "cell_type": "code", | ||
| "outputs": [], | ||
| "source": [ | ||
| "# Enable interactive selection of terminations via UI prompt\n", |
Member
There was a problem hiding this comment.
Line #21. TERMINATION_PAIR_INDEX = 0
TERMINATION_PAIR_INDEX # Will be overriden in interactive selection is used
Reply via ReviewNB
| @@ -0,0 +1,1079 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Line #6. materials = list(map(Material, globals()["materials_in"]))
Let's clean up the outputs
Reply via ReviewNB
timurbazhirov
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.