Skip to content

SOF-6535: new JSONSchema logic #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jul 28, 2023
Merged

SOF-6535: new JSONSchema logic #57

merged 40 commits into from
Jul 28, 2023

Conversation

@k0stik
Copy link
Member

@k0stik k0stik commented Jun 29, 2023

No description provided.

@k0stik k0stik changed the title SOF-6535: TS interfaces SOF-6535: new JSONSchema logic Jul 5, 2023
azech-hqs
azech-hqs reviewed Jul 11, 2023
View reviewed changes
azech-hqs
azech-hqs reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@azech-hqs azech-hqs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍
Note: there's still a conflict in package.json and some checks are not passing

azech-hqs
azech-hqs approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@azech-hqs azech-hqs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍
Note: the test for node 16.x is failing and there are two conflicts

@k0stik k0stik merged commit a69ba75 into main Jul 28, 2023
@k0stik k0stik deleted the update/SOF-6535 branch July 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@azech-hqs azech-hqs azech-hqs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k0stik @azech-hqs