SOF-7096: TS for math module #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/entity/in_memory.ts
Outdated
| const Entity = this.constructor as typeof InMemoryEntity; | ||
| clone<T extends InMemoryEntity>(extraContext?: object): T { | ||
| // @ts-ignore | ||
| const object: T = new this.constructor({ |
There was a problem hiding this comment.
Why do we need to use TS ignore?
There was a problem hiding this comment.
For some reason, typescript defines this.constructor as an ordinary function, not a constructor of some particular type. Everytime I try to access some properties or build a new object via new this.constructor it throws an error.
Changed this with typecasting typeof this as suggested here
https://stackoverflow.com/questions/33387318/access-to-static-properties-via-this-constructor-in-typescript
package.json
Outdated
| "@babel/register": "^7.16.0", | ||
| "@babel/runtime-corejs3": "7.16.8", | ||
| "@exabyte-io/esse.js": "2023.11.1-0", | ||
| "@exabyte-io/esse.js": "git+https://github.com/Exabyte-io/esse.git#update/SOF-7096", |
There was a problem hiding this comment.
Should be published version
timurbazhirov
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.