-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add TypeScript types for single-byte.js #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChALkeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot use method docs from README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive TypeScript type definitions for the single-byte.js module, enabling better type safety and IDE support for users of this encoding library.
Changes:
- Added complete TypeScript type definitions in
single-byte.d.tswith full JSDoc documentation matching the README - Updated
package.jsonto include the new type definitions in the exports configuration and files array - Made minor documentation improvements in README.md (reordered sections, changed "Will throw" to "Throws" for consistency)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| single-byte.d.ts | New TypeScript type definitions file with complete type declarations for all exported functions and interfaces, including detailed JSDoc documentation |
| package.json | Added single-byte.d.ts to files array and exports configuration to enable TypeScript support |
| README.md | Minor documentation improvements: reordered section content for better flow and standardized error documentation language |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChALkeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot rebase on main
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
6f12fa1 to
4424599
Compare
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Original prompt
single-byte.js#22💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.