fix: support jest snapshot matchers with snapshot name#25
Merged
sparten11740 merged 5 commits intomainfrom Feb 19, 2025
Merged
Conversation
mvayngrib
approved these changes
Feb 18, 2025
ChALkeR
reviewed
Mar 23, 2025
Collaborator
ChALkeR
left a comment
ChALkeR
left a comment
There was a problem hiding this comment.
nACK, tests in tests/jest subdir should pass on Jest, this doesn't
Collaborator
|
Will file a fix |
Contributor
Author
|
What do you mean? Why is that not run in the CI then? |
Collaborator
|
@sparten11740 you are right, we should ensure that Jest runs on tests in the tests/jest subdir or this can happen again #26 is a fix for the issue here (and an explanation), and #27 is the path forward |
Collaborator
Fixed in #29 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for passing a name to jest's snapshot matchers, e.g.
expect(obj).toMatchSnapshot('some snapshot name').Fixes #22