Skip to content

making propagation keys case insensitive#27

Merged
keshavpeswani merged 2 commits intomasterfrom
propagation-key-fix
Jan 30, 2019
Merged

making propagation keys case insensitive#27
keshavpeswani merged 2 commits intomasterfrom
propagation-key-fix

Conversation

@ashishagg
Copy link
Copy Markdown
Contributor

@ashishagg ashishagg commented Jan 30, 2019

HTTP RFC : https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

HTTP header fields, which include general-header (section 4.5), request-header (section 5.3), 
response-header (section 6.2), and entity-header (section 7.1) fields, follow the same generic format 
as that given in Section 3.1 of RFC 822 [9]. Each header field consists of a name followed by a colon
(":") and the field value. *Field names are case-insensitive.*

When SpanContext is extracted using TextMapPropagator, keys in the carrier can be of different case. In many cases, carrier is HttpHeadersCarrier which exposes HTTP headers read from transport. According to RFC, these header names are case insensitive. Some of the servers and clients do not maintain case of the header provided/read.

@keshavpeswani keshavpeswani merged commit c9321b2 into master Jan 30, 2019
@keshavpeswani keshavpeswani deleted the propagation-key-fix branch January 30, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants