Initial implementation#1
Merged
haystack-travis-admin merged 13 commits intoExpediaDotCom:masterfrom Mar 5, 2019
Merged
Conversation
Sarthak30
reviewed
Mar 4, 2019
|
|
||
| @abstractmethod | ||
| def inject(self, span_context, carrier): | ||
| pass |
There was a problem hiding this comment.
Can we throw an exception with a custom message? It will make it clear for any person that extends it.
Contributor
Author
There was a problem hiding this comment.
now raising NotImplemented Exception
| from .span import SpanContext | ||
| from opentracing import SpanContextCorruptedException | ||
|
|
||
| TRACE_ID = "Trace-ID" |
There was a problem hiding this comment.
Can we keep it in a separate file where all constants throughout the project can be defined?
Contributor
Author
There was a problem hiding this comment.
refactored to constants.py
|
|
||
|
|
||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
cleaned up, thanks!
… throw NotImplemented() from abstract classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Please review my implementation of haystack bindings for opentracing api. A few notes:
Thanks for checking this out.
Some To-Do's: