fix: Ignore arrow conversion when transformation is not used#313
Merged
Conversation
piket
force-pushed
the
refactor-optional-arrow
branch
from
2dbdfe3 to
d319b29
Compare
piket
force-pushed
the
refactor-optional-arrow
branch
from
614319c to
ac3ee38
Compare
piket
force-pushed
the
refactor-optional-arrow
branch
from
ac3ee38 to
a94424e
Compare
piket
force-pushed
the
refactor-optional-arrow
branch
from
83f94ef to
4ed695c
Compare
EXPEbdodla
approved these changes
Nov 21, 2025
Collaborator
EXPEbdodla
left a comment
EXPEbdodla
left a comment
There was a problem hiding this comment.
LGTM. Unit test failures seems intermittent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, results from an online store are always transformed into arrow arrays for use with the transformation service even if no transformation is requested. Later those arrow arrays are then transformed back into the proto values for the response. This adds unnecessary complexity and computation for the vast majority of use cases.
Which issue(s) this PR fixes:
This change checks whether transformations are needed and if not completely skips the arrow transformations.
Misc
Ran the Benchmark tests locally to generate these results: