fix: Modifying Batch Size Behaviour#327
Merged
Merged
Conversation
piket
approved these changes
Nov 25, 2025
kpulipati29
added a commit
that referenced
this pull request
Dec 3, 2025
--------- Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * feat: Redis range query materialization (#315) * feat: Redis range query materialization * fex: fix requirements * feat: Add batching and collocation * fix: fix formatting * fix: Add comment * fix: remove collocation * fix: add requirements files * fix: fix formatting * Update redis.py * Update test_redis.py * Update test_redis.py --------- Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * feat: Add Valkey changes (#317) * feat: Redis range query materialization * fex: fix requirements * feat: Add batching and collocation * fix: fix formatting * fix: Add comment * fix: remove collocation * fix: add requirements files * fix: fix formatting * Update redis.py * Update test_redis.py * Update test_redis.py * feat: Added valkey changes * fix: fix formatting --------- Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * fix: Exclude docker tests from macos (#319) * feat: Redis range query materialization * fex: fix requirements * feat: Add batching and collocation * fix: fix formatting * fix: Add comment * fix: remove collocation * fix: add requirements files * fix: fix formatting * Update redis.py * Update test_redis.py * Update test_redis.py * feat: Added valkey changes * fix: fix formatting * fix: exclude docker tests from macos * fix : fix formatting * fix : separate repo config with and without connection string * fix : separate repo config with and without connection string --------- Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * fix: Rename repo config (#320) * feat: Redis range query materialization * fex: fix requirements * feat: Add batching and collocation * fix: fix formatting * fix: Add comment * fix: remove collocation * fix: add requirements files * fix: fix formatting * Update redis.py * Update test_redis.py * Update test_redis.py * feat: Added valkey changes * fix: fix formatting * fix: exclude docker tests from macos * fix : fix formatting * fix : separate repo config with and without connection string * fix : separate repo config with and without connection string * fix : rename repoconfig * fix : formatting * fix : fix tests --------- Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * feat: Added Online Read Range functionality for Redis (#318) * added redis online read range functionality * using reverse instead of ZREVRANGE * adding reverse logic and valkey implementation * adding comments * moved util functionality into utils and addressed PR comments * reverting sample local changes --------- Co-authored-by: Manisha Sudhir <msudhir@expediagroup.com> * feat: Added Integration Tests for Valkey OnlineReadRange testing (#323) * added integration tests * Remove accidentally committed feast binary * adding ignore build integration --------- Co-authored-by: Manisha Sudhir <msudhir@expediagroup.com> * feat: Ttl changes (#311) * ttl changes * fix linting error * fixing the tests * updated the threading logic * fixing a typo * fix linting error * cleanup * cleanup * reformatting * pull max_evnts from feature view tags * fix import * Refactoring and added more unit tests * fix: formatting * formatting * fix tests * formatting * formatting * updated based on the materilaization changes * formatting * formatting * added valkey changes * bug fix * Address review comments * type * fix typo * formatting * fix failing unit tests * update tests * fix: Count ttl command * bug fix * Update sdk/python/feast/infra/online_stores/redis.py Co-authored-by: kpulipati29 <kpulipati29@gmail.com> * address review comments * lint fixes * fix: Enable event time ttl * fix: Use event timestamp to set ttl in redis hash * fix: linting * fix: imports * fix: imports * fix: Small fix * fix: Small fix * fix: exception handling and some cleanup * fix: formatting fix * fix: lint fix * fix: Reduce batch size * fix: reduce batch size * fix: dont expire if ttl is zerp --------- Co-authored-by: vbhagwat <vbhagwat@expediagroup.com> Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> Co-authored-by: kpulipati29 <kpulipati29@gmail.com> * fix: Fix minor bug (#324) * ttl changes * fix linting error * fixing the tests * updated the threading logic * fixing a typo * fix linting error * cleanup * cleanup * reformatting * pull max_evnts from feature view tags * fix import * Refactoring and added more unit tests * fix: formatting * formatting * fix tests * formatting * formatting * updated based on the materilaization changes * formatting * formatting * added valkey changes * bug fix * Address review comments * type * fix typo * formatting * fix failing unit tests * update tests * fix: Count ttl command * bug fix * Update sdk/python/feast/infra/online_stores/redis.py Co-authored-by: kpulipati29 <kpulipati29@gmail.com> * address review comments * lint fixes * fix: Enable event time ttl * fix: Use event timestamp to set ttl in redis hash * fix: linting * fix: imports * fix: imports * fix: Small fix * fix: Small fix * fix: exception handling and some cleanup * fix: formatting fix * fix: lint fix * fix: Reduce batch size * fix: reduce batch size * fix: dont expire if ttl is zerp * fix: add results for sfv --------- Co-authored-by: vbhagwat <vbhagwat@expediagroup.com> Co-authored-by: vanitabhagwat <92561664+vanitabhagwat@users.noreply.github.com> Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * removing limit on filter and adding it on retrieval (#326) Co-authored-by: Manisha Sudhir <msudhir@expediagroup.com> * modifying batch size behaviour (#327) Co-authored-by: Manisha Sudhir <msudhir@expediagroup.com> * fix: Adding Parallelization Logic (#328) * adding parallelization logic * modifying comment * adding logs for debugging * removing logs and cleaning up * removing logs and cleaning up * Add comments for better understandability --------- Co-authored-by: Manisha4 <Manisha4@github.com> * fix: Some bug fixes (#325) * ttl changes * fix linting error * fixing the tests * updated the threading logic * fixing a typo * fix linting error * cleanup * cleanup * reformatting * pull max_evnts from feature view tags * fix import * Refactoring and added more unit tests * fix: formatting * formatting * fix tests * formatting * formatting * updated based on the materilaization changes * formatting * formatting * added valkey changes * bug fix * Address review comments * type * fix typo * formatting * fix failing unit tests * update tests * fix: Count ttl command * bug fix * Update sdk/python/feast/infra/online_stores/redis.py Co-authored-by: kpulipati29 <kpulipati29@gmail.com> * address review comments * lint fixes * fix: Enable event time ttl * fix: Use event timestamp to set ttl in redis hash * fix: linting * fix: imports * fix: imports * fix: Small fix * fix: Small fix * fix: exception handling and some cleanup * fix: formatting fix * fix: lint fix * fix: Reduce batch size * fix: reduce batch size * fix: dont expire if ttl is zerp * fix: add results for sfv * fix: increase batch size * fix: fix a ttl bug * fix: Remove ttl logic to see if it improves latency * fix: some simplifications to ttl logic * fix: remove count based ttl * fix: add log * fix: formatting * fix: remove debug logs * fix: typo in test case * fix: linting * fix: increase ttl to see if that fixes tests * fix: lint * fix: improve tests --------- Co-authored-by: vbhagwat <vbhagwat@expediagroup.com> Co-authored-by: vanitabhagwat <92561664+vanitabhagwat@users.noreply.github.com> Co-authored-by: Krishna mohan Pulipati <kpulipati@expediagroup.com> * fix: Update Redis Implementation to Match Valkey (#329) * Port over valkey implementation to Redis * Fix bug and update tests * formatting fixes * formatting fixes --------- Co-authored-by: Manisha4 <Manisha4@github.com> * Update featurestore_test.go remove types2 import ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Modifying Batch Size Behaviour, reading batch size specified in the config
Which issue(s) this PR fixes:
Misc