Skip to content

fix: Elasticsearch online store - correctness, performance, and robustness fixes#353

Merged
vanitabhagwat merged 1 commit intofeature/vector-storefrom
fix/es-check-index-exists-before-create
Apr 1, 2026
Merged

fix: Elasticsearch online store - correctness, performance, and robustness fixes#353
vanitabhagwat merged 1 commit intofeature/vector-storefrom
fix/es-check-index-exists-before-create

Conversation

@vanitabhagwat
Copy link
Copy Markdown
Collaborator

@vanitabhagwat vanitabhagwat commented Mar 31, 2026

What this PR does / why we need it:

Fixes multiple bugs in the Elasticsearch online store:

  • Wrong data served: online_read returned results in ES hit order instead of input entity key order, causing features to be assigned to wrong entities
  • Silent data loss: No size param in ES query — only 10 results returned regardless of input size
  • O(n²m) write performance: insert_values list rebuilt inside inner loop on every feature of every entity
  • Frozen progress bar: progress callback never invoked during materialization
  • Keyword search blocked: vector_enabled check rejected keyword-only queries in retrieve_online_documents_v2
  • Bool type corruption: bool branch unreachable due to Python's bool subclassing int
  • Timestamp parsing: Hardcoded strptime formats replaced with datetime.fromisoformat()
  • Index existence guards: Added indices.exists() checks in update() and teardown()

Which issue(s) this PR fixes:

Misc

@vanitabhagwat vanitabhagwat force-pushed the fix/es-check-index-exists-before-create branch from 38fd03b to d97e9fa Compare March 31, 2026 23:15
@vanitabhagwat vanitabhagwat force-pushed the fix/es-check-index-exists-before-create branch from d97e9fa to 488c78f Compare March 31, 2026 23:18
@vanitabhagwat vanitabhagwat changed the title Fix/es check index exists before create Fix: Elasticsearch online store — correctness, performance, and robustness fixes Mar 31, 2026
@vanitabhagwat vanitabhagwat changed the title Fix: Elasticsearch online store — correctness, performance, and robustness fixes Fix: Elasticsearch online store - correctness, performance, and robustness fixes Mar 31, 2026
@vanitabhagwat vanitabhagwat changed the title Fix: Elasticsearch online store - correctness, performance, and robustness fixes fix: Elasticsearch online store - correctness, performance, and robustness fixes Apr 1, 2026
@vanitabhagwat vanitabhagwat changed the title fix: Elasticsearch online store - correctness, performance, and robustness fixes fix: Elasticsearch online store - correctness, performance, and robustness fixes Apr 1, 2026
@vanitabhagwat vanitabhagwat merged commit 7af68fb into feature/vector-store Apr 1, 2026
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants