Skip to content

Conversation

@dariuszkuc
Copy link
Collaborator

📝 Description

This PR introduces new graphql-kotlin Maven plugin with schema introspection functionality (same functionality as provided by Gradle plugin). This new plugin MOJO runs introspection query against target GraphQL endpoint and generates GraphQL schema based on the results.

PR size is very large due to inclusion of raw introspection result used for integration testing as well as Maven wrapper scripts - together those files amount to over 2300 lines of code.

NOTE: This is a 2nd PR that attempts to split up #595 into more manageable pieces. Subsequent PRs will follow with additional functionality.

🔗 Related Issues

None

This PR introduces new graphql-kotlin Maven plugin with schema introspection functionality (same functionality as provided by Gradle plugin). This new plugin MOJO runs introspection query against target GraphQL endpoint and generates GraphQL schema based on the results.

PR size is very large due to inclusion of raw introspection result used for integration testing as well as Maven wrapper scripts - together those files amount to over 2300 lines of code.

NOTE: This is a 2nd PR that attempts to split up ExpediaGroup#595 into more manageable pieces. Subsequent PRs will follow with additional functionality.
@dariuszkuc dariuszkuc added changes: minor Changes require a minor version type: documentation Documentation or test changes labels Apr 28, 2020
@smyrick
Copy link
Contributor

smyrick commented Apr 28, 2020

@dariuszkuc Do we need to somehow enable a local m2 repository directory for builds in actions?

@dariuszkuc
Copy link
Collaborator Author

@smyrick we don't have to do anything but it I think we could potentially use .m2 caching there as well. Unfortunately caching action does not support multiple paths atm (scheduled for v2) so we need to run it twice.

@smyrick
Copy link
Contributor

smyrick commented Apr 28, 2020

@dariuszkuc I meant as a way to fix the build. It looks like it was a code issue though. For implementing the action cache I think we can just skip that for now

@smyrick smyrick merged commit 5bd2d1a into ExpediaGroup:master Apr 28, 2020
@dariuszkuc dariuszkuc deleted the maven_plugin_introspection branch April 28, 2020 17:53
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* new Maven plugin with introspect schema mojo

This PR introduces new graphql-kotlin Maven plugin with schema introspection functionality (same functionality as provided by Gradle plugin). This new plugin MOJO runs introspection query against target GraphQL endpoint and generates GraphQL schema based on the results.

PR size is very large due to inclusion of raw introspection result used for integration testing as well as Maven wrapper scripts - together those files amount to over 2300 lines of code.

NOTE: This is a 2nd PR that attempts to split up ExpediaGroup#595 into more manageable pieces. Subsequent PRs will follow with additional functionality.

* fix copy-paste error

Integration test pom.xml file references project that will be added in subsequent PRs

* configure maven cache for integration tests

* missed one more dependency that will be added later on...

* update maven cache to account for java version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: minor Changes require a minor version type: documentation Documentation or test changes

Development

Successfully merging this pull request may close these issues.

2 participants