Skip to content

Conversation

@dariuszkuc
Copy link
Collaborator

📝 Description

Apply default codecs for JSON encoder/decoder without overwriting whole exchange strategies.

🔗 Related Issues

Resolves: #899

Apply default codecs for JSON encoder/decoder without overwriting whole exchange strategies.

Resolves: ExpediaGroup#899
@dariuszkuc
Copy link
Collaborator Author

Ideally it would be great if we could do something like create builder with defaults and then apply the builder provided by the user but based on the Spring docs there doesn't appear to be a simple way to do this.

Spring WebClient.Builder currently only expose apply(Consumer<WebClient.Builder> builderConsumer) which could be used to customize the builder but that would also complicate integrating client with Spring apps -> i.e. instead of autowiring beans managed by Spring users would have to explicitly provide lambda to customize the behavior. Unless Spring api changes I think this is probably the "best" we can do atm.

@smyrick smyrick added changes: patch Changes require a patch version type: bug Something isn't working labels Oct 8, 2020
@smyrick smyrick merged commit a2d781b into ExpediaGroup:master Oct 8, 2020
@dariuszkuc dariuszkuc deleted the webclient_codecs branch October 8, 2020 18:59
huehnerlady pushed a commit to huehnerlady/graphql-kotlin that referenced this pull request Oct 16, 2020
…oup#900)

Apply default codecs for JSON encoder/decoder without overwriting whole exchange strategies.

Resolves: ExpediaGroup#899
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
…oup#900)

Apply default codecs for JSON encoder/decoder without overwriting whole exchange strategies.

Resolves: ExpediaGroup#899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: patch Changes require a patch version type: bug Something isn't working

Development

Successfully merging this pull request may close these issues.

Can't overwrite default buffer size

2 participants