[HOLD for payment 2023-06-30] [$1000] Clicking on 'Didn't receive a magic code' after being offline spins the loader infinitely in the button

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to android latest one
2. Log out if already signed in
3. Make sure you are on login page
4. Enter email and click on continue
5. Now be offline
6. Click on 'Didn't receive a magic code' and notice that the loader spins infinitely

Expected Result:

Clicking on 'Didn't receive a magic code' after being offline should not spin the loader infinitely in the button and should throw an error

Actual Result:

Clicking on 'Didn't receive a magic code' after being offline spins the loader infinitely in the button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

spin.mp4

az_recorder_20230422_192911.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682142890351589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0149391e81535c09d1
• Upwork Job ID: 1651626813261238272
• Last Price Increase: 2023-04-27

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0149391e81535c09d1

[MelvinBot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[adelekennedy]

woof yeah let's fix this one - though I wonder if this will need to be internal?