[NEED CHECKLIST] [$2000] Inconsistent margin for reacted emojis to different sort of comments

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. open a chat
2. send a pic, code block, strike-through text, normal comment, multi-line code block.
3. Now react to all of these with some emoji

Expected results:

margin should be same in each comment

Actual results:

different margin in different type of comments

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.541.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683646365352769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb4e86a533ae3fac
• Upwork Job ID: 1656675989014130688
• Last Price Increase: 2023-06-09
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26608577
• chiragxarora | Reporter | 26608579

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin between different type of comments.

What is the root cause of that problem?

The multi-line code block comment has margin vertical 8px.

App/src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/BasePreRenderer.js

Line 35 in 45c3212

style={[styles.mv2, styles.overscrollBehaviorNone]}

The same with the heading comment

App/src/styles/styles.js

Lines 136 to 139 in 45c3212

	h1: {
	fontSize: variables.fontSizeLarge,
	marginBottom: 8,
	},

So that if comment has multi-line code block or heading at the end of itself, reacted emojis is further than the others.

Besides the heading comment has margin top default that is rendered by react-native-render-html is 9.38px so it is misaligned.

What changes do you think we should make in order to solve the problem?

We could pass containerStyles to ReportActionItemReactions component. If the comment has h1 or pre tag at the end, we will pass the styles mt0 or mt2 if otherwise.

App/src/components/Reactions/ReportActionItemReactions.js

Line 74 in 45c3212

style={[styles.flexRow, styles.flexWrap, styles.gap1, styles.mt2]}

What alternative solutions did you explore? (Optional)

NA

[chiragxarora]

Margins for image and normal comment also look different from what I see on the app @dukenv0307

[dukenv0307]

@chiragxarora The reason is normal comment has text in the vertical middle with font-size less than wrap component. So it has a little more distance from the wrap component, making us think margin relative to reacted emojis is different from image.

[chiragxarora]

Ohh I get it now, but I think that should be adjusted accordingly so that all margins appear consistent to the end user

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb4e86a533ae3fac

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)