[HOLD for payment 2023-06-23] [$1000] Chat - Assignee is not displayed and displayed only in share some where field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login
2. Open a new chat
3. Click the + icon and select assign task
4. Enter title and description
5. Click Next

Expected Result:

Assignee displayed as task is selected from DM

Actual Result:

Assignee is not displayed and displayed only in share some where field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.10

Reproducible in staging?: Yes

Reproducible in production?: New feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6057474_Assignee.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013972c69da5584f0a
• Upwork Job ID: 1659250926006640640
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No default assignee is displayed when create a assign task in a single chat

What is the root cause of that problem?

We don't set assignee value the same as shareDestination if we are creating a task from a report

App/src/pages/tasks/NewTaskPage.js

Lines 88 to 93 in 3bee6f9

	// We only set the parentReportID if we are creating a task from a report
	// this allows us to go ahead and set that report as the share destination
	// and disable the share destination selector
	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}

What changes do you think we should make in order to solve the problem?

We could create a function in TaskUtils same as setAssignValueWithParentReportID that gets reportID as argument. To check the report has is a DM and not is group chat we can use the way same as in ReportWelcomeText component by checking isDefault && !isMultipleParticipant

App/src/components/ReportWelcomeText.js

Lines 54 to 58 in e4c5c54

	const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(props.report);
	const isChatRoom = ReportUtils.isChatRoom(props.report);
	const isDefault = !(isChatRoom || isPolicyExpenseChat);
	const participants = lodashGet(props.report, 'participants', []);
	const isMultipleParticipant = participants.length > 1;

And then if this check above is true, we will set assignee for task is a participant of the report that has reportID is the parameter passed in . And in here we will call this function created above : setAssignValueWithParentReportID(props.task.parentReportID)

App/src/pages/tasks/NewTaskPage.js

Lines 88 to 93 in 3bee6f9

	// We only set the parentReportID if we are creating a task from a report
	// this allows us to go ahead and set that report as the share destination
	// and disable the share destination selector
	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013972c69da5584f0a

[adelekennedy]

moving to external!

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.