[$1000] Web - When deleting a message, you cannot use arrows to toggle between "Delete" and "Cancel"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Write a message on composer and send it
2. Edit it by pressing arrow key up and delete the entire message and hit enter
3. A modal opens asking if you want to confirm the deletion
4. Hit left arrow to attempt to cancel the message

Expected Result:

In the delete box, you cannot select the cancel button with arrows

Actual Result:

Message gets deleted because you cannot focus the cancel button with arrow keys.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-06-22.10_26_02.PM.1.mp4

Recording.5176.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dan1d
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687483418798109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018188fb2901398792
• Upwork Job ID: 1675046551407325184
• Last Price Increase: 2023-07-08

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - When deleting a message I cannot move to cancel with arrows

What is the root cause of that problem?

Delete button has pressOnEnter props, but Cancel button doesn't have it. So, although focus is changed to Cancel button, Cancel button will not clicked by clicking Enter key.

App/src/components/ConfirmContent.js

Lines 66 to 73 in 98bb603

	<Button
	success={props.success}
	danger={props.danger}
	style={[styles.mt4]}
	onPress={props.onConfirm}
	pressOnEnter
	text={props.confirmText || props.translate('common.yes')}
	/>

What changes do you think we should make in order to solve the problem?

If both buttons have pressOnEnter props, it will be only effected to the last button only.
Without pressOnEnter props, Enter key works for focused button.
So Remove pressOnEnter from Delete button

<Button
    success={props.success}
    danger={props.danger}
    style={[styles.mt4]}
    onPress={props.onConfirm}
    text={props.confirmText || props.translate('common.yes')}
/>
)}

What alternative solutions did you explore? (Optional)

We can add pressOnEnter props on Delete button when there is no Cancel button

<Button
    success={props.success}
    danger={props.danger}
    style={[styles.mt4]}
    onPress={props.onConfirm}
    text={props.confirmText || props.translate('common.yes')}
    pressOnEnter={!props.shouldShowCancelButton}
/>

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - When deleting a message I cannot move to cancel with arrows

What is the root cause of that problem?

pressOnEnter prop is not passed to cancel button

What changes do you think we should make in order to solve the problem?

In cancel button pass pressOnEnter here

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

Reassigning another bug team member, I'm going OOO until Monday, July 10, and will take it back if it's still open by my return date.

Required action from the 🐛 team: I've run out of time and haven't tested this one yet. This GH needs testing to confirm if it's a bug, check if it's a dupe, and then assign the applicable labels. Thank you!

[jliexpensify]

I can repro, but the original issue steps aren't clear and don't specifically focus on the issue. I've edited it now.