[WAITING ON MIROSLAV FOR PAYMENT] [HOLD for payment 2023-10-02] [$1000] content of input jumps from top to bottom in multi-line inputs

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. create a task
2. open the task
3. write a long multi-line description and save it
4. now open the description and observe the input field and scrollbar in RHP

Expected Result:

content should be at bottom at the time of rendering

Actual Result:

content of input jumps from top to bottom

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-06-24.18-12-20-493.mp4

Recording.1111.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687610858267479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ef411cb69302ae1
• Upwork Job ID: 1673690266454241281
• Last Price Increase: 2023-09-12
• Automatic offers:
• 0xmiroslav | Reviewer | 26723385
• chiragxarora | Contributor | 26723386
• chiragxarora | Reporter | 26723387

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Content of Input jumps from top to bottom in multi-line input

What is the root cause of that problem?

We set focus on the input after transition ends as you can see below

App/src/pages/tasks/TaskDescriptionPage.js

Line 65 in 96e534a

onEntryTransitionEnd={() => inputRef.current && inputRef.current.focus()}

So focus is set after the transition ends and the modal is shown fully. This is the root cause

What changes do you think we should make in order to solve the problem?

When we add autoFocus props to the TextInput component, its focusing is done in BaseTextInput component below.

App/src/components/TextInput/BaseTextInput.js

Line 71 in be7b6a0

input.current.focus();

We can use focusAndUpdateMultilineInputRange function in order to set cursor at the last position combining with autoFocus.

1. Add the autoFocus props to TextInput component and remove the onEntryTransitionEnd from ScreenWrapper in TaskDescriptionPage

2. Use the focusAndUpdateMultilineInputRange function in useEffect of BaseTextInput. Replace the below code
   

   App/src/components/TextInput/BaseTextInput.js

   Lines 67 to 71 in be7b6a0

   	if (props.shouldDelayFocus) {
   	focusTimeout = setTimeout(() => input.current.focus(), CONST.ANIMATED_TRANSITION);
   	return;
   	}
   	input.current.focus();

   
   with

        if (props.shouldDelayFocus) {
            focusTimeout = setTimeout(() => focusAndUpdateMultilineInputRange(input.current), CONST.ANIMATED_TRANSITION);
            return;
        }

        focusAndUpdateMultilineInputRange(input.current);

, where focusAndUpdateMultilineInputRange function is from the libs/focusAndUpdateMultilineInputRange.js

This works as expected on all platforms.

Result

21654_mac_chrome.mp4

What alternative solutions did you explore? (Optional)

[chiragxarora]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Content jumps from top to bottom in multi line input in task description page

What is the root cause of that problem?

Root cause is the late setting of focus using ref because initially cursor is placed at top and later it is brought down using selection prop. And when we focus after this, it shows the jump behaviour.

App/src/pages/tasks/TaskDescriptionPage.js

Line 65 in 96e534a

onEntryTransitionEnd={() => inputRef.current && inputRef.current.focus()}

What changes do you think we should make in order to solve the problem?

What other proposal above suggested defeats the purpose of our logic of solving transition issue since on Android it will cause problems. To tackle this in a different way, we have another prop called shouldDelayFocus which we should pass along with autoFocus and then we can get rid of the focus via ref.

<TextInput
........
autoFocus
shouldDelayFocus = {shouldDelayFocu}
.........
>
<TextInput/>

Ofcourse we need to import the shouldDelayFocus prop first.
This will put an Android specific delay for the TextInput

Update:

There have been some changes in the file and now we are no longer using setting the selection in useEffect and we have introduced a new util focusAndUpdateMultilineInputRange.
We can use a callback ref on the textinput now to focus the field as it mounts, and we can add conditional delay for the android using shouldDelayFocus.

Updated code:

const inputRefCallback = useCallback((el) => {
        if(!el) {
            return;
        }
        focusMultilineUsingCallbackRef(el, inputRef);
        inputRef.current = el;
}, []);

..........................

<TextInput 
   ref={inputRefCallback}
>
...................

export default function focusMultilineUsingCallbackRef(el, inputRef) {
    if(inputRef.current) {
        return;
    }
    if(shouldDelayFocus) {
        setTimeout(() => {
            focusAndUpdateMultilineInputRange(el);    
        }, CONST.ANIMATED_TRANSITION);
    }
    else focusAndUpdateMultilineInputRange(el);
}

Results

bandicam.2023-07-03.16-22-12-723.mp4

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ef411cb69302ae1

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[abekkala]

@0xmiroslav have you had a chance to review the proposals that have come in so far?