[HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [$500] DEV: Web - Unable to paste copied text into emoji search box

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Right click any text > Copy
3. Open Emoji picker
4. Click on emoji search text box
5. Attempt to paste copied text into the emoji search text input

Expected Result:

Text pasted into emoji search text input successfully

Actual Result:

Emoji search text remains empty after text paste attempt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev v1.3.44-0
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-24.at.3.11.51.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @honnamkuan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690183117515199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a88b8b12d4216db
• Upwork Job ID: 1683594984549310464
2023-07-24
• Automatic offers:
• | | 0
• honnamkuan | Reporter | 25727250

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to paste copied text into emoji search box.

What is the root cause of that problem?

In EmojiPickerMenu, there is no paste handler, only have keydown handler and mousemove handler.

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 149 to 201 in a906877

	this.keyDownHandler = (keyBoardEvent) => {
	if (keyBoardEvent.key.startsWith('Arrow')) {
	if (!this.state.isFocused || keyBoardEvent.key === 'ArrowUp' || keyBoardEvent.key === 'ArrowDown') {
	keyBoardEvent.preventDefault();
	}
	// Move the highlight when arrow keys are pressed
	this.highlightAdjacentEmoji(keyBoardEvent.key);
	return;
	}
	// Select the currently highlighted emoji if enter is pressed
	if (!isEnterWhileComposition(keyBoardEvent) && keyBoardEvent.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey && this.state.highlightedIndex !== -1) {
	const item = this.state.filteredEmojis[this.state.highlightedIndex];
	if (!item) {
	return;
	}
	const emoji = lodashGet(item, ['types', this.props.preferredSkinTone], item.code);
	this.addToFrequentAndSelectEmoji(emoji, item);
	return;
	}
	// Enable keyboard movement if tab or enter is pressed or if shift is pressed while the input
	// is not focused, so that the navigation and tab cycling can be done using the keyboard without
	// interfering with the input behaviour.
	if (keyBoardEvent.key === 'Tab' || keyBoardEvent.key === 'Enter' || (keyBoardEvent.key === 'Shift' && this.searchInput && !this.searchInput.isFocused())) {
	this.setState({isUsingKeyboardMovement: true});
	return;
	}
	// We allow typing in the search box if any key is pressed apart from Arrow keys.
	if (this.searchInput && !this.searchInput.isFocused()) {
	this.setState({selectTextOnFocus: false});
	this.searchInput.focus();
	// Re-enable selection on the searchInput
	this.setState({selectTextOnFocus: true});
	}
	};
	// Keyboard events are not bubbling on TextInput in RN-Web, Bubbling was needed for this event to trigger
	// event handler attached to document root. To fix this, trigger event handler in Capture phase.
	document.addEventListener('keydown', this.keyDownHandler, true);
	// Re-enable pointer events and hovering over EmojiPickerItems when the mouse moves
	this.mouseMoveHandler = () => {
	if (!this.state.arePointerEventsDisabled) {
	return;
	}
	this.setState({arePointerEventsDisabled: false});
	};
	document.addEventListener('mousemove', this.mouseMoveHandler);

So user is unable to paste text into emoji search box.

What changes do you think we should make in order to solve the problem?

We can add paste handler in EmojiPickerMenu.

    this.pasteHandler = (event) => {
        if (!this.searchInput) {
            return;
        }
        const text = (event.clipboardData || window.clipboardData).getData('text');
        this.searchInput.value += text;
        this.filterEmojis(this.searchInput.value);
    }

And remove handler in cleanupEventHandlers.

    document.removeEventListener('keydown', this.pasteHandler);

What alternative solutions did you explore? (Optional)

None.

[daordonez11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy paste does not work in the EmojiPickerMenu component

What is the root cause of that problem?

Due to recent changes in the Composer component handlePaste method now begins with the event.preventDefault method:

App/src/components/Composer/index.js

Lines 309 to 323 in a906877

	handlePaste(event) {
	event.preventDefault();
	const isVisible = this.props.checkComposerVisibility();
	const isFocused = this.textInput.isFocused();
	if (!(isVisible || isFocused)) {
	return;
	}
	if (this.textInput.id !== event.target.id) {
	return;
	}
	const {files, types} = event.clipboardData;

This makes it work for the parent/first mounted component but preventing default behavior ends up in preventing other handlers/inputs to work as expected. Hence the expected native handler of the input does nothing.

What changes do you think we should make in order to solve the problem?

As it was before move event.preventDefault() after the validations so it is indeed prevented only if the logic does apply to the current composer, something like this:

 handlePaste(event) {
        const isVisible = this.props.checkComposerVisibility();
        const isFocused = this.textInput.isFocused();

        if (!(isVisible || isFocused)) {
            return;
        }

        if (this.textInput.id !== event.target.id) {
            return;
        }
        event.preventDefault();

Video of solution working:

23470.solution.working.webm

What alternative solutions did you explore? (Optional)

Create a new handler in the component but is just not tackling it in the root.
Also, not sure if it makes sense but using Composer in this TextInput? Still less disruptive just to tackle it in the root and avoid unnecessary handlers.
PS: I think this might be a regression of 23135 @Santhosh-Sellavel

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a88b8b12d4216db

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.