[HOLD for payment 2023-08-28] [$1000] Web - Login - Tooltip displays message as if the invalid phone number is an incomplete email

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Enter an invalid phone number - 123456789.
3. Press Enter.
4. Hover over the email/phone number field.

Expected Result:

Tooltip displays appropriate message about the invalid phone number.

Actual Result:

Tooltip displays message as if the invalid phone number is an incomplete email.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6141968_bandicam_2023-07-26_15-37-53-873.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0105fc16028a40e971
• Upwork Job ID: 1684994827918065664
• Last Price Increase: 2023-08-04
• Automatic offers:
• fedirjh | Reviewer | 26045564
• samh-nl | Contributor | 26045566
• chiragxarora | Reporter | 26045569

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip displays message as if the invalid phone number is an incomplete email

What is the root cause of that problem?

The input in LoginForm.js has a type="email" attribute due to keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS}, leading to the browser validating it as such. However, we utilize our own validation and the browser's validation is therefore redundant.

What changes do you think we should make in order to solve the problem?

1. We should add the attribute novalidate to the form element that wraps the input in LoginForm.js:

App/src/components/SignInPageForm/index.js

Lines 15 to 20 in fdcae9f

	// Password Managers need these attributes to be able to identify the form elements properly.
	this.form.setAttribute('method', 'post');
	this.form.setAttribute('action', '/');
	this.form.addEventListener('submit', this.preventFormDefault);

this.form.setAttribute('novalidate', '');

2. This change should also be applied to the form containing an email/phone number input in NewContactMethodPage.js, which can be done in FormSubmit.

Here, we should add:

useEffect(() => {
    innerRef.current.setAttribute('novalidate', '');
}, []);

And add accessibilityRole={ComponentUtils.ACCESSIBILITY_ROLE_FORM} to:

App/src/components/FormSubmit/index.js

Lines 43 to 47 in fdcae9f

	<View
	ref={innerRef}
	onKeyDownCapture={submitForm}
	style={style}
	>

Lastly, here we should also prevent the default behavior upon form submit (which is already done in SignInPageForm).

What alternative solutions did you explore? (Optional)

Option 1. Change the input type to text, however this would have side-effects that degrade the UX.
Option 2. Dynamically change the input type based on what is entered, e.g. if it starts with a plus or number it's probably a phone number. However, this is more of an experimental approach that may or may not be liked.

[chiragxarora]

DUPE of #18250 (comment)
and it was decided not to fix last time
cc @kevinksullivan

[kevinksullivan]

Going to add @chiragxarora . This seems like a bug and worth fixing IMO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0105fc16028a40e971

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.