[$1000] Web - Chat - Not all styles apply to Code Block

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Open any conversation
3. Send the code block format (HELLO) to the conversation.
4. send the code block format (HELLO) to the conversation.
5. Send the code block format (HELLO) to the conversation.
6. Send the code block format (HELLO) to the conversation.

Expected Result:

When sending a text in code block format with different styles applied, the chat should display the text with the applied style in code block format

Actual Result:

When a user sends text in code block format with different styles applied, chat only displays the strikethrough text in code block, other styles are not working.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6144837_Recording_Reg_23765_Web.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014744c92382103aae
• Upwork Job ID: 1687127223831072768
• Last Price Increase: 2023-08-03

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not all styles apply to code block, bold and italic doesn't work

What is the root cause of that problem?

Here is the markdown -> html rules in ExpnsiMark
https://github.com/s-alves10/expensify-common/blob/98d8fea356f114f8b5b0cea889a41b355e5daf58/lib/ExpensiMark.js#L188-L205

As you can see, we are actively refusing italic and bold when there is <pre> tag. This is the root cause

What changes do you think we should make in order to solve the problem?

It looks like an intentional behavior.
Anyway, we can remove the <pre> condition from both rules.

This works as expected

What alternative solutions did you explore? (Optional)

[greg-schroeder]

Posted in Slack because I'm not sure which is the best solution - should we just leave the rule in place and apply it to all styles, or remove it across the board?

[greg-schroeder]

Bumped slack thread

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014744c92382103aae

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.