[HOLD for payment 2023-08-28] [$1000] Unintended Drop to Upload Feature Triggered When Holding Links

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat.
2. Write a link and hold the link by right-clicking and moving it.
3. Notice that the "Drop to Upload" feature appears.

Expected Result:

The "Drop to Upload" feature should not be triggered when holding links.

Actual Result:

After writing a link and holding it by right-clicking and moving it, the "Drop to Upload" feature is unexpectedly triggered.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-01T103954.311.mp4

Recording.1429.mp4

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690911489720949
https://expensify.slack.com/archives/C049HHMV9SM/p1690887772771919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016dae7b2ac425d362
• Upwork Job ID: 1686831554804891648
• Last Price Increase: 2023-08-02
• Automatic offers:
• samh-nl | Contributor | 25976718

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unintended Drop to Upload Feature Triggered When Holding Links

What is the root cause of that problem?

We set setIsDraggingOver(true); if dragging is occurring, without checking if the dragged content/file is compatible with what is provided in shouldAcceptDrop.

App/src/components/DragAndDrop/Provider/index.js

Lines 16 to 18 in 751d797

	function shouldAcceptDrop(event) {
	return _.some(event.dataTransfer.types, (type) => type === 'Files');
	}

App/src/hooks/useDragAndDrop.js

Lines 66 to 73 in 751d797

	case DRAG_ENTER_EVENT:
	dragCounter.current++;
	setDropEffect(event);
	if (isDraggingOver) {
	return;
	}
	setIsDraggingOver(true);
	break;

What changes do you think we should make in order to solve the problem?

We should check that shouldAcceptDrop returns true before setting isDraggingOver / setDropEffect.

What alternative solutions did you explore? (Optional)

Alternatively, we can keep the current behavior but add an extra condition to ensure that shouldAcceptDrop returns true when rendering the overlay:

App/src/components/DragAndDrop/Provider/index.js

Line 42 in 751d797

{isDraggingOver && (

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unintended Drop to Upload Feature Triggered When Holding Links

What is the root cause of that problem?

We still setDropEffect with the files that has shouldAllowDrop or shouldAcceptDrop were false, which caused the issue.

App/src/hooks/useDragAndDrop.js

Lines 63 to 86 in 530b455

	case DRAG_OVER_EVENT:
	setDropEffect(event);
	break;
	case DRAG_ENTER_EVENT:
	dragCounter.current++;
	setDropEffect(event);
	if (isDraggingOver) {
	return;
	}
	setIsDraggingOver(true);
	break;
	case DRAG_LEAVE_EVENT:
	dragCounter.current--;
	if (!isDraggingOver || dragCounter.current > 0) {
	return;
	}
	setIsDraggingOver(false);
	break;
	case DROP_EVENT:
	dragCounter.current = 0;
	setIsDraggingOver(false);
	onDrop(event);
	break;

What changes do you think we should make in order to solve the problem?

Add more condition to our existing early return here to prevent this issue:

            if (!isFocused || isDisabled || !shouldAllowDrop || !shouldAcceptDrop(event)) {
                return;
            }

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016dae7b2ac425d362

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[huzaifa-99]

@maddylewis @kavimuru can you please use my name for the reporter? I reported here on the same day 6 hrs before this report.