[HOLD for payment 2023-08-28] Android - App crashes when tapping on Amount in IOU details page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app
2. Request money from any user
3. Open IOU report
4. Tap on IOU preview
5. Tap on Amount

Expected Result:

Amount page opens

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168013_Screen_Recording_20230817_193752_One_UI_Home.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Looking into this, must be after this migration #24345

[Skalakid]

@mountiny I think the app crashes because of the lack of accessibilityLabel inside CurrencySymbolButton when disabled is true. I propose improving the condition inside accessibilityLabel like:

accessibilityLabel={disabled ? currencySymbol : translate('iOUCurrencySelection.selectCurrency')}

[mountiny]

@Skalakid Will work on this, thanks, just saw it in the console and trying to run android to confirm

[koko57]

if it's about disabled prop - my PR should fix this one (we're removing disabling the button)