[HOLD for payment 2023-08-28] [$500] Request money - The app crashes when user deleted the request money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap Fab
3. Tap request money
4. Tap enter any amount
5. Tap next
6. Select any user
7. Tap Request money
8. Tap last transaction to open the last requested money page
9. Tap the money requested
10. In IOU details page, tap 3 dots to select "delete request"
11. Tap delete request

Expected Result:

The request money should be deleted

Actual Result:

The app crashes when user deleted the request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168801_new_crash.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Ingernal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b8ef599b7ac8134d
• Upwork Job ID: 1692480853057089536
• Last Price Increase: 2023-08-18
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26194635
• pradeepmdk | Contributor | 26194639

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Request money - The app crashes when the user deleted the request money]

What is the root cause of that problem?

after delete request title is 0 here 0 is number

App/src/components/MenuItem.js

Line 134 in 404cefb

accessibilityLabel={props.title}

this PR add this https://github.com/Expensify/App/pull/20251/files accessibilityLabel

What changes do you think we should make in order to solve the problem?

we need fix the type to string here accessibilityLabel
possiblity to get title is null or undefined

                    accessibilityLabel={props.title ? props.title.toString() : ''}

we need fix below those as well. all should be an type error only.

result

Screen.Recording.2023-08-18.at.10.35.57.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b8ef599b7ac8134d