[HOLD for C+ newdot payment] [$1000] Burger menu overlaps with "Expensify" logo in top left corner of the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1.Login and then open Settings.
2.open help.

Expected Result:

Drawer button should not overlay on Expensify logo.

Actual Result:

Drawer button is overlaying on Expensify logo.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenrecorder-2023-08-12-14-49-47-769.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Harshizonnet
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691834089242369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5ada1183af69b00
• Upwork Job ID: 1693866584422825984
• Last Price Increase: 2023-08-22
• Automatic offers:
• getusha | Contributor | 26399647

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Burger menu overlaps with "Expensify" logo in top left corner of the page. Also search icon is requires some padding/margin.

What is the root cause of that problem?
There is no margin added to Logo and search icon.

Since the position is absolute other elements can take the space so that overlap is visible.

App/docs/_sass/_main.scss

Lines 277 to 292 in 120bcbf

	.logo {
	width: 160px;
	align-content: center;
	display: block;
	margin-left: auto;
	margin-right: auto;
	@include breakpoint($breakpoint-tablet) {
	width: 210px;
	align-content: normal;
	display: flex;
	margin-left: 0;
	margin-right: 0;
	}
	}
	}

What changes do you think we should make in order to solve the problem?

There are two changes are required:

• Add 30px margin to logo
• Set logo with 200 for min devices (i.e. 800)

        .logo {
            width: 160px;
            align-content: center;
            display: block;
            margin-right: auto;
-           margin-left: auto;
+           margin-left: 30px;
            @include breakpoint($breakpoint-tablet) {
-           width: 210px;
+           width: 200px;
                align-content: normal;
                display: flex;
                margin-left: 0;
                margin-right: 0;
            }
        }

Screen devices with 800px width

Mobile devices

Additionally, I suggest reducing the padding of the header container. Then there won't be any need to change the logo size.

Result with padding: 30px;

Result with padding: 40px;

Just noticed that 24px margin/padding used everywhere so update it to keep consistent.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5ada1183af69b00

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN toggle icon overlaps with 'expensify' logo

What is the root cause of that problem?

The header button is positioned absolute which makes it overlap with any other element if the viewport is resized to it's break point.

App/docs/_sass/_main.scss

Line 270 in 6609308

position: absolute;

What changes do you think we should make in order to solve the problem?

We should remove the position absolute from here:

App/docs/_sass/_main.scss

Line 270 in 6609308

position: absolute;

and add padding-right: 24px which seems the standard in our case (used on the header padding)

then we will move the header button to the element below inside "flex"

App/docs/_layouts/default.html

Lines 25 to 28 in 6609308

	<div id="header-button">
	<img id="angle-up-icon" src="/assets/images/arrow-up.svg" class="base-icon hide"></img>
	<img id="bars-icon" src="/assets/images/menu.svg" class="base-icon"></img>
	</div>

move this to inside

App/docs/_layouts/default.html

Lines 29 to 37 in 6609308

	<div class="flex">
	<div>
	<a href="/">
	<img src="/assets/images/expensify-help.svg" class="logo" />
	</a>
	</div>
	<!-- Search icons that'll open the Sidebar Search sections -->
	{% include search-toggle.html %}
	</div>

we can also improve the search icon by resizing the logo on the right break point.

App/docs/_sass/_main.scss

Line 284 in 6609308

@include breakpoint($breakpoint-tablet) {

we will change $breakpoint-tablet with $breakpoint-desktop

What alternative solutions did you explore? (Optional)

[alitoshmatov]

I think it is regression of #24299