[$1000] Settings - Help - Not auto focusing on search field for Help page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login and then open Settings.
2. Open help.
3. Tap on search icon.

Expected Result:

When user tap on search icon it opens search tab but not focusing on Search field, keyboard should open on android/ios devices.

Actual Result:

When user tap on search icon ,Search field should be focused, keyboard should open on android/ios devices.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.4.webm

Recording.4383.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Harshizonnet
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694070713281919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01884263b0de13d0a5
• Upwork Job ID: 1701248465382961152
• Last Price Increase: 2023-11-01
• Automatic offers:
• aimane-chnaif | Reviewer | 27657496
• getusha | Contributor | 27657498
• Harshizonnet | Reporter | 27657499

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01884263b0de13d0a5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search field not auto focused when opening side bar on help page

What is the root cause of that problem?

In

App/docs/assets/js/main.js

Lines 102 to 116 in 1ae51cc

	function openSidebar() {
	document.getElementById('sidebar-layer').style.display = 'block';
	// Make body unscrollable
	const yAxis = document.documentElement.style.getPropertyValue('y-axis');
	const body = document.body;
	body.style.position = 'fixed';
	body.style.top = `-${yAxis}`;
	// Close the sidebar when clicking sidebar layer (outside the sidebar search)
	const sidebarLayer = document.getElementById('sidebar-layer');
	if (sidebarLayer) {
	sidebarLayer.addEventListener('click', closeSidebarOnClickOutside);
	}
	}

We are not focusing the search field when we open the sidebar, inside openSidebar function.

What changes do you think we should make in order to solve the problem?

We should select the search field using it's id which is gsc-i-id1 and focus the input programmatically when openSidebar function is triggered, using:

document.getElementById('gsc-i-id1').focus()

We will just add it here

@@ -108,6 +108,8 @@ function openSidebar() {
     body.style.position = 'fixed';
     body.style.top = `-${yAxis}`;
+    document.getElementById('gsc-i-id1').focus();

Result

Screen.Recording.2023-09-11.at.6.07.47.PM.mov

### What alternative solutions did you explore? (Optional)