[HOLD for payment 2023-11-02] [$500] Android - Quickly pressing different menu items in WS Options opens them one by one

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open RHS, click on workspaces open any workspace.
2. Quickly press different menu items.

Expected Result:

Only first option should be open other click ignores (same as settings page and LHN)

Actual Result:

The app opens all the clicked options

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-09-11-16-51-59.mp4

Screen_Recording_20230913_140926_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694431310368759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013563910034c3c70d
• Upwork Job ID: 1702024671852146688
• Last Price Increase: 2023-09-13
• Automatic offers:
• ishpaul777 | Contributor | 27096906
• ishpaul777 | Reporter | 27096909

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013563910034c3c70d

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[ishpaul777]

Proposal

Problem

Quickly pressing different menu items in WS Options opens them one by one

Root Cause

We are allowing other action when a action is already in progress in workspace.

Changes

We can use useSingleExecution hook along with useWaitForNavigation to ignore the other action when navigation in progress, similar to what we have done in InitialSettingsPage

1. modify every action in menuItems in workspaceInitialPage similar to action in InitialSettingsPage

2 modify onPress in workspaceInitialPage similar to onPress in InitialSettingsPage

3. add disabled={isExecuting} in MenuItem in WorkspaceInitialPage.

Alternative

We can use useFocusEffect hook from react-navigation, and disable MenuItem when isNavigating is true

const isNavigating = useRef(false)
    useFocusEffect(
        React.useCallback(() => {
           isNavigating.current = false

            return () => {
                isNavigating.current = true
            };
        }, [])
    );
``

[CortneyOfstad]

@michaelhaxhiu There is a known issue (more info here) with duplicate assignees. Unassigning you 👍