[$250] DEV: `CMD + C` does not show in Keyboard shortcuts modal immediately after login

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Immediately after login and while the LHN is still skeleton, Press CMD + J to toggle Keyboard shortcuts modal
3. Observe that CMD + C is NOT there
4. Close the modal then re-open it
5. Observe that CMD + C is there

Expected Result:

CMD + C shows in Keyboard shortcuts modal immediately after login

Actual Result:

CMD + C does not show in Keyboard shortcuts modal immediately after login unless we open the modal again

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

262831456-843e1214-a516-4e64-b4cc-aab21dfd2609.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695026209099819

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017a7cfe6708754ab2
• Upwork Job ID: 1706173740282531840
• Last Price Increase: 2023-10-04
• Automatic offers:
• tienifr | Contributor | 27030222
• tienifr | Reporter | 27030224

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal by #tienifr

Please re-state the problem that we are trying to solve in this issue.

CMD + C does not show in Keyboard shortcuts modal immediately after login unless we reopened the modal.

What is the root cause of that problem?

In here, we're getting the list of shortcuts to display, but we're using the method KeyboardShortcut.getDocumentedShortcuts which retrieves a static value documentedShortcuts from another file, so when documentedShortcuts is updated in the other file, we don't have any knowledge of it, so the UI is not updated.
So when new shortcuts are subscribed, for example in here, the UI is not updated.

What changes do you think we should make in order to solve the problem?

We should create a listener that subscribes to documentedShortcuts changes:

• Add shortcutsUpdateCallback in src/libs/KeyboardShortcut/index.js
• In listener, assign shortcutsUpdateCallback to the callback from the modal
• When updating the documentedShortcuts, call the shortcutsUpdateCallback as well
• Add the listener to useEffect of the modal
  It's just a few lines of additional changes, we already use the same listener approach in various places in the app (ReportActionComposeFocusManager, Notification, ...).

What alternative solutions did you explore? (Optional)

We can also create a useDocumentedShortcuts for the above implementation in here and use it instead of the getDocumentedShortcuts, when the documentedShortcuts changes (a shortcut is subscribed, unsubscribed), we'll update the state in the hook as well. Then use the hook in KeyboardShortcutsModal, this will make sure KeyboardShortcutsModal is always updated via hook with the latest value of documentedShortcuts.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017a7cfe6708754ab2

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[melvin-bot]

@jliexpensify, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!