[$500] PR 27825 RM - Save button should remain disabled until something is entered in the input field.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App
2. Open Request Money > Distance
3. Open the Start waypoint
4. Press Save without selecting any address.

Expected Result:

If we don't enter anything atleast "Save" button should be disabled.

Actual Result:

App returns to the previous page when tap on the save button. Save button should remain disabled until something is entered in the input field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-6

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208917_27825_desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01153f7357f12f779a
• Upwork Job ID: 1706211261961732096
• Last Price Increase: 2023-09-25

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Found when validating PR : #27825

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button should remain disabled until something is entered in the input field

What is the root cause of that problem?

We don't have any validation in case the waypointValue is empty

App/src/pages/iou/WaypointEditor.js

Line 106 in 603dc58

const validate = (values) => {

What changes do you think we should make in order to solve the problem?

We can add validation like this

 if (waypointValue === '') {
            ErrorUtils.addErrorMessage(errors, `waypoint${waypointIndex}`, 'common.error.fieldRequired');
        }

If we want to apply this validation only for start point and finish point we can add condition like this

 if (waypointValue === '') {
            ErrorUtils.addErrorMessage(errors, `waypoint${waypointIndex}`, 'common.error.fieldRequired');
        }

Result

[rajsixthblock]

### Proposal

Please re-state the problem that we are trying to solve in this issue.
Save button should be disabled until field is empty

What is the root cause of that problem?
Save button by default showing Active all the time, we need to disable the button

What changes do you think we should make in order to solve the problem?
We have to check input field is empty or not . we need to disable the save button by passing the value of input field as props from Form component to FormAlertWithSubmitButton component, using that value we need to write condition to disable or enable the button in FormAlertWithSubmitButton component

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01153f7357f12f779a

[melvin-bot]

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.