[HOLD for payment 2023-11-17] [$250] Clean the usage of double onyx call on profile page

[techievivek]

Problem

We currently have used a double onyx call on the profile page to subscribe to the DM chat report in order for notification preference to update correctly for the profile page. This was reported during PR review here: #28200 (comment)

App/src/pages/ProfilePage.js

Lines 306 to 317 in a63f853

	// eslint-disable-next-line rulesdir/no-multiple-onyx-in-file
	withOnyx({
	report: {
	key: ({route, session}) => {
	const accountID = Number(lodashGet(route.params, 'accountID', 0));
	if (Number(session.accountID) === accountID || Session.isAnonymousUser()) {
	return null;
	}
	return `${ONYXKEYS.COLLECTION.REPORT}${lodashGet(ReportUtils.getChatByParticipants([accountID]), 'reportID', '')}`;
	},
	},
	}),

Discussed here: #28200 (comment)

Why is this important?

Using a double Onyx subscription for any component is not a recommended practice so it would be nice to clean that up. Moreover, we have now enabled the notification preference option for all the chat reports so maybe we can create a separate component for the notification preference page and reuse that across various pages.

Solution

Create a separate component for notification preference and get rid of the double onyx call on the profile page. Feel free to come up with your own solutions.

Here is a potential solution to the problem: #28200 (comment)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013768a6222352d168
• Upwork Job ID: 1711676109112000512
• Last Price Increase: 2023-10-24
• Automatic offers:
• pradeepmdk | Contributor | 27435339

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013768a6222352d168

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[techievivek]

Bug0 triage checklist is not required for this GH, as this is just a code improvement issue.

Dibs