[$500] Search - Reply in thread on invite message displays undefined/fake in search

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83.10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697184595029359

Action Performed:

1. Open the app
2. Open any workspace chat in which you were invited
3. Hover on invited message and click on reply in thread
4. Open search and observe that below reply in thread report, undefined/fake is displayed

Expected Result:

App should display workspace name or user email below reply in thread report in search which has no messages

Actual Result:

App displays undefined/fake below reply in thread report in search for reply in thread on invite message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

android.app.undefined.below.reply.in.thread.mp4

Android: mWeb Chrome

android.chrome.undefined.below.reply.in.thread.mp4

iOS: Native

ios.native.undefined.below.reply.in.thread.search.mov

iOS: mWeb Safari

ios.chrome.undefined.reply.in.thread.search.mov

MacOS: Chrome / Safari

mac.chrome.undefined.below.reply.in.thread.search.mov

Recording.4980.mp4

MacOS: Desktop

mac.desktop.undefined.below.reply.in.thread.search.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168e11378d36ee4bc
• Upwork Job ID: 1712825221601480704
• Last Price Increase: 2023-10-27

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0168e11378d36ee4bc

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays undefined/fake below reply in thread report in search for reply in thread on invite message

What is the root cause of that problem?

We're displaying the reply in thread option for Whisper report action, which doesn't have enough data to display in the Search since it's supposed to be "User-only visible option". It will have lastActorAccountID as 0 since this is a whisper action and it's correct that there's no actor to it since it's preconfigured message.

What changes do you think we should make in order to solve the problem?

We should disable "Reply in thread" functionality for Whisper report action, since there's no point replying to a message that is only to you and other people can't see it.

We should add a condition to exclude isWhisper report action here. We can use the isWhisperAction util

return (isCommentAction || isReportPreviewAction || isIOUAction) && !ReportActionsUtils.isWhisperAction(reportAction);

What alternative solutions did you explore? (Optional)

If we want to keep the ability to create thread on whisper message, we can make sure enough data is returned to display the proper subtitle in search.

But this is like optimizing something that shouldn't exist 😄

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When replying in thread on invite message in workspace chat, undefined/fake appears in chats search

What is the root cause of that problem?

For policy chat, we show lastMessageText as alternateText as you can see below

App/src/libs/OptionsListUtils.js

Line 508 in 9e19e40

result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;

lastMessageText consists of {actor}: {message}

App/src/libs/OptionsListUtils.js

Lines 492 to 495 in 9e19e40

	const lastMessageTextFromReport = getLastMessageTextForReport(report);
	const lastActorDetails = personalDetailMap[report.lastActorAccountID] || null;
	let lastMessageText = hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID ? `${lastActorDetails.displayName}: ` : '';
	lastMessageText += report ? lastMessageTextFromReport : '';

When creating a new thread, lastActorAccountID is set to 0 as you can see

App/src/libs/ReportUtils.js

Line 2620 in 9e19e40

lastActorAccountID: 0,

This is the root cause

What changes do you think we should make in order to solve the problem?

For threads, we can use the actorAccountID of parentReportAction as lastActorAccountID if lastActorAccountID is empty(0)
Update

App/src/libs/OptionsListUtils.js

Line 493 in 9e19e40

const lastActorDetails = personalDetailMap[report.lastActorAccountID] || null;

to

        let lastActorAccountID = report.lastActorAccountID;
        if (result.isThread) {
            if (!lastActorAccountID) {
                const parentReportAction = ReportActionUtils.getReportAction(report.parentReportID, report.parentReportActionID);
                lastActorAccountID = lodashGet(parentReportAction, 'actorAccountID', 0);
            }
        }
        const lastActorDetails = personalDetailMap[lastActorAccountID] || null;

Result

29567.mp4

What alternative solutions did you explore? (Optional)

We can set parentReportAction.actorAccountID to lastActorAccountID when creating a thread

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When reply in thread is done on a workspace invite message, the search page displays undefined/fake as subtitle.

What is the root cause of that problem?

As shown here, we initialise the lastMessageText with the last actor’s display name. Now, since we are dealing with a whisper action that does not have all the required data, lastActorAccountID within report will contain 0. The local storage uses the display from within the personal details map which will return __fake__. If local storage of personal details map does not contain an entry for accountID 0, it will return undefined.

Further, as shown here, since lastMessageText contains fake value, it will get assigned. This is the root cause for displaying fake text in search page.

What changes do you think we should make in order to solve the problem?

1. We can ignore invalid actor account id by checking if the value is 0 by making changes here like this below. This way, lastMessageText will not contain fake value.

	const lastActorDetails = report.lastActorAccountID !== 0 ? personalDetailMap[report.lastActorAccountID] || null : null;

2. Additionally, the subtitle will return empty for thread as shown here. We can additionally check for isPolicyExpenseChat as shown below so that the workspace name can be displayed

    if (isChatThread(report) && !isPolicyExpenseChat(report)) {
        return '';
    }

What alternative solutions did you explore? (Optional)