[HOLD for payment 2023-11-21] [$500] Search - Reply in thread on workspace chat page message displays no content below title

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83.10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697187645873449

Action Performed:

1. Open the app
2. Open workspace chat generated when you invited someone to one of your group (hint whether it is right chat: it won't have invite message in top)
3. Send any message
4. Hover on message and click reply in thread
5. Open search and observe that reply in thread report has no text below its title

Expected Result:

App should display workspace name below title of report of reply in thread in search

Actual Result:

App displays no text below title of report of reply in thread in search for reply in thread from workspace chat of workspace of which you are admin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

android.native.reply.in.thread.empty.below.mp4

Android: mWeb Chrome

android.chrome.reply.in.thread.empty.below.mp4

iOS: Native

ios.native.reply.in.thread.empty.below.mov

iOS: mWeb Safari

ios.safari.reply.in.thread.empty.below.mov

MacOS: Chrome / Safari

windows.chrome.reply.in.thread.below.search.mp4

mac.chrome.reply.in.thread.empty.below.mov

Recording.4984.mp4

MacOS: Desktop

Recording.4984.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01605da73f2c7f8650
• Upwork Job ID: 1712837332771098624
• Last Price Increase: 2023-10-13
• Automatic offers:
• bernhardoj | Contributor | 27557241
• dhanashree-sawant | Reporter | 27557243

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01605da73f2c7f8650

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[graylewis]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user replies in a thread in a workspace (that the user is an admin of) and then that thread is displayed as an option on the search page there is no text under the title of the thread

What is the root cause of that problem?

Because the thread is considered part of the workspace and the user is an admin of that workspace, the createOption method is given a forcePolicyNamePreview value of true. The forcePolicyNamePreview variable is there to force the name of the workspace to be the subtitle of the search option for the workspace itself. This is not the intended behavior for threads originating from that workspace, however.

What changes do you think we should make in order to solve the problem?

We should add a check in the calculation of the alternateText (the text under the title of a search option) to make sure that forcePolicyNamePreview is not taken into account for a thread, as it should only be applied to workspaces. (One other option which is potentially more robust I explore in my alternative solutions).

Before:

result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ?lastMessageText : subtitle;

After:

result.alternateText = showChatPreviewLine && (!forcePolicyNamePreview || result.isThread) && lastMessageText ? lastMessageText : subtitle;

What alternative solutions did you explore? (Optional)

It's a little bit strange to me that the logic for workspace expense chats is mixed with the logic for chatrooms:

if (result.isChatRoom || result.isPolicyExpenseChat) {
            result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
        }

This is especially strange considering that there is a property that shouldn't be considered for chat rooms being taken into account (forcePolicyNamePreview). Another solution that is granted a little more of a refactor (higher risk for regressions) would be to move the logic for policyExpenseChats to another if block, and calculate result.alternateText seperately. This would ensure that chats that aren't from a workspace aren't affected by forcePolicyNamePreview.

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reply in thread on workspace chat page message displays no content below title.

What is the root cause of that problem?

A chat thread in a workspace is always treated as regular chat room entry in the search options list. So that it will always display either lastMessageText or subtitle. In this case it's an empty subtitle.

App/src/libs/OptionsListUtils.js

Lines 507 to 509 in 9e19e40

	if (result.isChatRoom || result.isPolicyExpenseChat) {
	result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
	} else if (result.isMoneyRequestReport) {

What alternative solutions did you explore? (Optional)

If we want to display the workspace name for a chat reply in a workspace, I suggest that we treat the alternateText for policy expense report in a separate block, e.g.:

if (result.isChatRoom) {
    result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
} else if (result.isPolicyExpenseChat) {
    result.alternateText = ReportUtils.getPolicyName(report)
}

Result:

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace thread has no workspace name in the search option

What is the root cause of that problem?

We are setting the option's alternateText here:

App/src/libs/OptionsListUtils.js

Lines 507 to 508 in be54929

	if (result.isChatRoom || result.isPolicyExpenseChat) {
	result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;

At this point, we are returning the subtitle, but it is '' returned from here:

App/src/libs/ReportUtils.js

Lines 1875 to 1878 in ca5127f

	function getChatRoomSubtitle(report) {
	if (isChatThread(report)) {
	return '';
	}

I'm not sure where gentlemen from other proposals get the statement about forcePolicyNamePreview being false here, as it is passed as true which can be seen during debugging:

What changes do you think we should make in order to solve the problem?

And we shouldn't touch the logic of the checks in result.alternateText = ..., as it is used not only in the search but also in Request Money flows, for example.

Instead, we should add a fallback value to show the policy name if the subtitle is empty. This will ensure we do not overwrite the custom subtitle in Request Money flows:

function getChatRoomSubtitle(report) {
        if (result.isChatRoom || result.isPolicyExpenseChat) {
            result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText
                ? lastMessageText
-               : subtitle;
+               : (!_.isEmpty(subtitle) ? subtitle : ReportUtils.getPolicyName(report));
        }

In this case, we'll return the last default return statement – return getPolicyName(report), which is exactly what we need. And it won't break the subtitle in Request Money flow compared to the proposal above.

What alternative solutions did you explore? (Optional)

There was an idea stated above (and now below s well) that says we should do the following:

- result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
+ result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : ReportUtils.getPolicyName(report);

It is not correct because in this case, we'll duplicate Workspace name in both Title and alternateText on the RequestMoney flow:

Where it should be the actual subtitle - "Workspace":

[dummy-1111]

This looks quite similar to #29567

What's important is what to show at the 2nd line in search
Here is my suggestion: #29567 (comment)