[$500] Android - Scan - '+n' box in the expense preview has monotone design compared to other platforms

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Create more than three Scan requests in workspace chat
3. Go to the workspace chat
   Take a look at the '+n' box in the expense preview and see the difference between Android app and web app

Expected Result:

The '+n' box in the expense preview on Android app shares the same design as the web app

Actual Result:

The '+n' box in the expense preview on Android app does not have two shades of triangles compared to other platforms (web, mweb, desktop and iOS app)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb1eaa9608e54e7c
• Upwork Job ID: 1714384161488551936
• Last Price Increase: 2023-10-24
• Automatic offers:
• abdulrahuman5196 | Reviewer | 27443578
• eh2077 | Contributor | 27443580

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb1eaa9608e54e7c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The +n text of receipt images only has one color on Android compared to other platforms where there are 2 different colors.

What is the root cause of that problem?

The +n triangle has a style below

App/src/styles/styles.ts

Lines 3754 to 3766 in 9664f8c

	reportActionItemImagesMoreCornerTriangle: {
	position: 'absolute',
	bottom: 0,
	right: 0,
	width: 0,
	height: 0,
	borderStyle: 'solid',
	borderWidth: 0,
	borderBottomWidth: 40,
	borderLeftWidth: 40,
	borderColor: 'transparent',
	borderBottomColor: theme.cardBG,
	},

To show the highlighted red triangle background color below, we set it through borderColor (shorthand) and borderBottomColor as you can see from the code above.

After doing some investigation, setting both borderColor (shorthand) and border*Color doesn't work.

What changes do you think we should make in order to solve the problem?

Set the border color one by one.

borderTopColor: 'transparent',
borderLeftColor: 'transparent',
borderRightColor: 'transparent',
borderBottomColor: theme.cardBG,

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Scan - '+n' box in the expense preview has monotone design compared to other platforms.

What is the root cause of that problem?

The root cause of this issue is that the way we draw triangle is not working in RN of Android, see

App/src/styles/styles.ts

Lines 3755 to 3767 in b3c4419

	reportActionItemImagesMoreCornerTriangle: {
	position: 'absolute',
	bottom: 0,
	right: 0,
	width: 0,
	height: 0,
	borderStyle: 'solid',
	borderWidth: 0,
	borderBottomWidth: 40,
	borderLeftWidth: 40,
	borderColor: 'transparent',
	borderBottomColor: theme.cardBG,
	},

We're using borderWith (and border*Width) and borderColor (and border*Color) to create the shape of triangle, which is a common method to create triangle from web but things become tricky on RN when working with border with transparent color, see RN issue related to border and transparent.

What changes do you think we should make in order to solve the problem?

To solve this issue, instead of drawing triangle using borderWidth and borderColor, we can use Svg and Polygon from react-native-svg to draw the triangle we need.

To achieve it, we replace this line with

<Svg 
    height={triangleWidth} 
    width={triangleWidth} 
    style={{ position: 'absolute' }}
>
    <Polygon
        points={`${triangleWidth},0 ${triangleWidth},${triangleWidth} 0,${triangleWidth}`}
        fill={isHovered ? theme.border : theme.cardBG}
    />
</Svg>

and define triangle width variable like

const triangleWidth = variables.reportActionItemImagesMoreCornerTriangleWidth; // 40

See demo

0-android.mp4

What alternative solutions did you explore? (Optional)

N/A

[abdulrahuman5196]

Will review proposals over the weekend.