[HOLD for payment 2023-11-13] [$500] Chat - After creating a money request, email are first displayed, then changed to set name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.91-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to FAB -> Request money -> Manually -> Use an account with set user name -> Request

Expected Result:

The immediately installed username is displayed at the top of the page

Actual Result:

At the top of the page, first, the email is displayed, and then it changes to the set username

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6252081_1698337680025.Recording__6558.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ef7eaea70e5f02e1
• Upwork Job ID: 1717582124675444736
• Last Price Increase: 2023-10-26
• Automatic offers:
• s77rt | Reviewer | 27438378
• bernhardoj | Contributor | 27438383

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ef7eaea70e5f02e1

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[peymancyb]

I am checking this issue 👀

[cooldev900]

Proposal

from: @cooldev900

Please re-state the problem that we are trying to solve in this issue.

After creating a money request, email are first displayed, then changed to set name in LHN.

What is the root cause of that problem?

The root cause is because it returns displayName at the first time after creating a money request instead of firstname and lastname.
At that time, the displayName in allPersonalDetails[accountID] Object is an email address that represents user's login content.

App/src/libs/ReportUtils.js

Lines 1175 to 1179 in cb5aeb1

	return (
	(allPersonalDetails && allPersonalDetails[accountID]) || {
	avatar: UserUtils.getDefaultAvatar(accountID),
	}
	);

App/src/libs/ReportUtils.js

Lines 1189 to 1197 in cb5aeb1

	function getDisplayNameForParticipant(accountID, shouldUseShortForm = false) {
	if (!accountID) {
	return '';
	}
	const personalDetails = getPersonalDetailsForAccountID(accountID);
	const longName = personalDetails.displayName;
	const shortName = personalDetails.firstName || longName;
	return shouldUseShortForm ? shortName : longName;
	}

What changes do you think we should make in order to solve the problem?

So we need to check if the personalDetail includes firstName and lastNae and if it doesn't include, we can return displayName.

function getDisplayNameForParticipant(accountID, shouldUseShortForm = false) {
    if (!accountID) {
        return '';
    }
    const personalDetails = getPersonalDetailsForAccountID(accountID);
    const shortName = personalDetails.firstName || personalDetails.lastName || personalDetails.displayName || '';
    const longName = personalDetails.firstName ||  personalDetails.lastName ? `${personalDetails.firstName || ''} ${personalDetails.lastName || ''}` : personalDetails.displayName || ''
    return shouldUseShortForm ? shortName : longName;
}

What alternative solutions did you explore? (Optional)

If we don't want to change getDisplayNameForParticipant function, the backend should return correct displayName that include firstName and lastName in personalDetail. And we need to sync personalDetails data to backend when selecting participants in requesting money and also other user selection cases.

Result

Video_2023-10-26_215420-mac-chrome_20231026215533.mp4

[s77rt]

@cooldev900 Thanks for the proposal. I don't think your RCA is correct. From what I can tell and based on the attached screenshot, we re-creating the personalDetails item object even though we have it. And by doing so we are overwriting the displayName field. Can you please recheck if that's the case?

[cooldev900]

@s77rt
Yes, you are right. The personalDetails item object is updated, but it takes some time to update, so initially the LHN displays the title using existing personalDetails item (including email) and then when updated, it displays the updated content again(firstName and lastName). That's why we can see two different titles in LHN within for a short period of time.