[$500] Request Money - Entering 08 and navigating back to BNP shows 8 but after selecting a contact shows 08

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.92.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money
4. Enter amount 08
5. Tap next
6. Tap app back button and navigate back to BNP and note 8 is displayed
7. Again enter amount 08
8. Tap next
9. Select a contact
10. Tap app back button and navigate back to BNP and note 08 is displayed

Expected Result:

The app behaviour should be consistent, when user enters 08 and tap next and navigate back to BNP, it should show 08.

Actual Result:

When user enters 08 and tap next and navigate back to BNP, it shows 8.But when user selects a contact and navigate back to BNP, 08 is shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6253105_1698400381222.zero8.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018d87f0b6872da9ba
• Upwork Job ID: 1717883745136267264
• Last Price Increase: 2023-10-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018d87f0b6872da9ba

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[erquhart]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount field value should remain consistent. When entering 08, it is sometimes reformatted to 8, and sometimes not. If we reformat, we should do so consistently.

What is the root cause of that problem?

A useEffect is only running when the amount prop changes on the MoneyRequestAmountForm component. This happens when the user navigates forward and then back as the prop changes from 0 to 800, but on further back/forth navigations, when changing from "08" to "8" or vice-versa in the input, the underlying value remains 800, so the useEffect doesn't trigger formatting.

This is a component state issue only, app state is correct.

Hook in reference here:
https://github.com/Expensify/App/blob/main/src/pages/iou/steps/MoneyRequestAmountForm.js#L107-L119

What changes do you think we should make in order to solve the problem?

Run formatting on submit as well. This a one-line-ish change that doesn't otherwise alter expected behavior.

Expensify-30505.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @erquhart! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[erquhart]

Contributor details
Your Expensify account email: shawn@erquh.art
Upwork Profile Link: https://www.upwork.com/freelancers/~0167bac4bfb3d7aa6c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!