[HOLD for payment 2023-12-15] [$500] Chat - The Emoji search field is focused when clicking on Modifier keys

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698154419378969

Action Performed:

1. Go to any Chat
2. Blur the main composer(Unfocus the main composer)
3. Click on Modifier keys like 'cmd'. Notice that the composer is not focused
4. Click on the emoji in the composer to open the emoji section. 5. unfocus the emoji search field.
5. Click on Modifier keys like 'cmd'. Notice that the composer is focused

Expected Result:

The Emoji search field is not focused when clicking on Modifier keys

Actual Result:

The Emoji search field is focused when clicking on Modifier keys

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

t7keyboardFocus.Desktop.1.mp4

t7keyboardFocus.macChrome.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011a4c2fb2e41d1f1c
• Upwork Job ID: 1720501550008877056
• Last Price Increase: 2023-11-17
• Automatic offers:
• dukenv0307 | Contributor | 27820697
• daveSeife | Reporter | 27820699

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011a4c2fb2e41d1f1c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[DrLoopFall]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Emoji search field is focused when clicking on Modifier keys

What is the root cause of that problem?

We are currently focusing emoji picker's search input whenever a key is pressed,

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 325 to 327 in aa30ef2

	if (searchInputRef.current && !searchInputRef.current.isFocused()) {
	searchInputRef.current.focus();
	}

What changes do you think we should make in order to solve the problem?

Only focus the search input if the user presses the keys which would add text to the input.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Emoji search field is focused when clicking on Modifier keys

What is the root cause of that problem?

The conditions for autofocusing via keypress for emoji picker here and composer here are not aligned

What changes do you think we should make in order to solve the problem?

We need to add the missing rules from composer autofocus logic to the emoji picker autofocus logic

For this specific issue, using this rule in here should be enough, but we should consider other rules as well to make it consistent and avoid similar bugs.

// If the key pressed is non-character keys like Enter, Shift, ... do not focus
if (keyBoardEvent.key.length > 1) {
    return;
}

This should also be used:

// If a key is pressed in combination with Meta, Control or Alt do not focus
if (keyBoardEvent.metaKey || keyBoardEvent.ctrlKey || keyBoardEvent.altKey) {
    return;
}

Since many rules can be reused between the composer and the emoji picker (and any other input that requires autofocusing on key press), we can create an util shouldAutoFocusOnKeyPress(event) to wrap the shared logic (some rules are not shared though so we still need to check those few case by case)

What alternative solutions did you explore? (Optional)

NA

[dylanexpensify]

@robertKozik can we review these proposals today, please?