[HOLD for payment 2024-01-17] [HOLD for payment 2023-12-15] [$500] Bank account - Fields with emojis are not turned red and general error message is shown

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR: #31259
Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Open the app
2. Navigate to Workspace > Bank account > Connect manually
3. Enter routing and account number
4. Enter emojis in Legal name, address and city fields
5. Fill out the rest with test data and tap "Continue"

Expected Result:

The fields with emojis are highlighted in red and the error message to enter valid info is displayed

Actual Result:

The general error message "Auth SetupWithdrawalAccount returned an error" is displayed, and the fields are not turned red.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277839_1700065315673.video_2023-11-15_10-41-07.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01087f0962c58f5f4a
• Upwork Job ID: 1724828495604215808
• Last Price Increase: 2023-11-15
• Automatic offers:
• tienifr | Contributor | 27782542

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01087f0962c58f5f4a

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Fields with emojis are not turned red and general error message is shown

What is the root cause of that problem?

We did not verify if the value contains emoji to show the error

What changes do you think we should make in order to solve the problem?

We should use CONST.REGEX.EMOJIS (or extractEmojis function) to check if the text contain emoji, if yes, render the error

text.match(CONST.REGEX.EMOJIS);

then add this check here and other places if needed

Detail implementation:

To validate companyName and addressCity:

 if (values.companyName && !ValidationUtils.isValidLegalName(values.companyName)) {
            errors.companyName = 'bankAccount.error.companyName';
        }

if (values.addressCity && !ValidationUtils.isValidLegalName(values.addressCity)) {
            errors.addressCity = 'bankAccount.error.addressCity';
        }

To validate addressStreet, we already have function isValidAddress, we can change this line

to

if (!isValidLegalName(value)) {

What alternative solutions did you explore? (Optional)

Instead of just limiting emojis, we can restrict user input to only allow specific character ranges (we may use the same regex from BE side)

[parasharrajat]

We can use ValidationUtils.isValidLegalName for these fields but the overall idea is correct. The address field requires more changes. But the idea is correct.

let's go with @tienifr's proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.