[$500] Web - Workspace - Default Currency Updated Without Clicking "Save" Button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Settings > Workspaces > Settings.
2. Change name and default currency and click on the save button.
3. Again open Settings, click on Default currency.
4. Select another currency and click on the back button.
5. Click on Settings again.

Expected Result:

Default currency should be saved only when clicking the "Save" button.

Actual Result:

Default currency is updated without clicking on the "Save" button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6285795_1700585212242.2023-11-21_21-24-02.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ffcbf11fadef142e
• Upwork Job ID: 1727011964987805696
• Last Price Increase: 2023-11-21

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ffcbf11fadef142e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

currency is saved without clicking save.

What is the root cause of that problem?

we update the currency on select from currency list not when clicking on save

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Lines 73 to 76 in e87d35d

	const onSelectCurrency = (item) => {
	Policy.updateGeneralSettings(policy.id, policy.name, item.keyForList);
	Navigation.goBack(ROUTES.WORKSPACE_SETTINGS.getRoute(policy.id));
	};

What changes do you think we should make in order to solve the problem?

simlar to the iou currency param prop we should add a new param currency which is used to pass the selected currency to the workspace setting page

so in the

-        Policy.updateGeneralSettings(policy.id, policy.name, item.keyForList);
-        Navigation.goBack(ROUTES.WORKSPACE_SETTINGS.getRoute(policy.id));        
+        Navigation.navigate(`${ROUTES.WORKSPACE_SETTINGS.getRoute(policy.id)}?currency=${item.keyForList}`);
 

then in the workspace setting page we look for the currency param and if its there the currency should be update:

    const currentCurrency = lodashGet(route, 'params.currency', '');
    let currency = '';
    if (CurrencyUtils.isValidCurrencyCode(currentCurrency)) {
        currency = currentCurrency;
    } else if (!_.isEmpty(policy)) {
        currency = policy.outputCurrency;
    }

    const formattedCurrency = !_.isEmpty(currencyList) ? `${currency} - ${currencyList[currency].symbol}` : '';

and finally, update the policy.outputCurrency here to currency

POC

Screen.Recording.2023-11-21.at.7.52.49.PM.mov

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Workspace - Default Currency Updated Without Clicking "Save" Button

What is the root cause of that problem?

In the current logic, we update currency immediately after clicking on currency in picker

What changes do you think we should make in order to solve the problem?

We can create a new field on ONYX called modifiedCurrency (maybe save it on the policy field). Then, when the user clicks currency in the picker (excepted current currency), we will update modifiedCurrency field with pendingAction
We only call updateGeneralSettings when user click save button and here we will pass modifiedCurrency as params. we also need to clear pending action of modifiedCurrency field

What alternative solutions did you explore? (Optional)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Default Currency Updated Without Clicking "Save" Button

What is the root cause of that problem?

Because currency updated when select from currency list.

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Line 73 in 0cca90a

const onSelectCurrency = (item) => {

What changes do you think we should make in order to solve the problem?

1. We don't need update currency onWorkspaceSettingsCurrencyPage
2. when select currency, we need to navigate.back with currency parameter.
3. On WorkspaceSettingsPage, we need to get currency from currency parameter(if exist).
4. when submit on WorkspaceSettingsPage, we need to update currency together(selected)

What alternative solutions did you explore? (Optional)

[fedirjh]

This is a duplicate of :

• [$250] Workspace - Make workspace name input push to page #29455

and it should be fixed with :

• Feat/push page ws name #30733